Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 1921633003: [Telemetry] Rename page_test to legacy_page_test (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Add TODO Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index 9a4fbb44356e507e872e82d8846de54e8d7cdf2a..e9667510935aafcfd6ab3dd3404dbc2538589d12 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -16,7 +16,7 @@ from telemetry.internal.browser import browser_info as browser_info_module
from telemetry.internal.platform.profiler import profiler_finder
from telemetry.internal.util import exception_formatter
from telemetry.internal.util import file_handle
-from telemetry.page import page_test
+from telemetry.page import legacy_page_test
from telemetry import story
from telemetry.util import image_util
from telemetry.util import wpr_modes
@@ -299,7 +299,7 @@ class SharedPageState(story.SharedState):
if self._current_page.credentials:
if not self.browser.credentials.LoginNeeded(
self._current_tab, self._current_page.credentials):
- raise page_test.Failure(
+ raise legacy_page_test.Failure(
'Login as ' + self._current_page.credentials + ' failed')
self._did_login_for_current_page = True
@@ -332,7 +332,7 @@ class SharedPageState(story.SharedState):
# Avoid trying to recover from an unknown multi-tab state.
exception_formatter.PrintFormattedException(
msg='Telemetry Error during multi tab test:')
- raise page_test.MultiTabTestAppCrashError
+ raise legacy_page_test.MultiTabTestAppCrashError
raise
except Exception:
if self._finder_options.browser_options.take_screenshot_for_failed_page:
« no previous file with comments | « telemetry/telemetry/page/page_test_unittest.py ('k') | telemetry/telemetry/page/shared_page_state_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698