Renaming _openssl files to _impl

net/android/keystore_impl.h

Index: net/android/keystore_impl.h
diff --git a/net/android/keystore_openssl.h b/net/android/keystore_impl.h
similarity index 85%
rename from net/android/keystore_openssl.h
rename to net/android/keystore_impl.h
index 2de4e0a8125fb3a5a8a0563f2093f2e66fb14ac8..a84db4abc990659c4d20ac0f89168342d78f45e8 100644
--- a/net/android/keystore_openssl.h
+++ b/net/android/keystore_impl.h
@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef NET_ANDROID_KEYSTORE_OPENSSL_H
-#define NET_ANDROID_KEYSTORE_OPENSSL_H
+#ifndef NET_ANDROID_KEYSTORE_IMPL_H
+#define NET_ANDROID_KEYSTORE_IMPL_H

[davidben, 2016/04/25 16:14:19]

This file I'd actually leave alone since it's glue between the keystore and
OpenSSL. Also keystore.h exists and this isn't the implementation for
keystore.h. (Though we should do away with this file and use SSLPrivateKey.)

[svaldez, 2016/04/25 20:26:35]

Done.

 
 #include <jni.h>
 #include <openssl/evp.h>
@@ -11,8 +11,7 @@
 #include "crypto/scoped_openssl_types.h"
 #include "net/base/net_export.h"
 
-// OpenSSL-specific functions to use the Android platform keystore.
-// The features provided here are highly specific to OpenSSL and are
+// The features provided here are highly implementation specific and are
 // segregated from net/android/keystore.h because the latter only provides
 // simply JNI stubs to call Java code which only uses platform APIs.
 
@@ -47,4 +46,4 @@ NET_EXPORT crypto::ScopedEVP_PKEY GetOpenSSLPrivateKeyWrapper(
 }  // namespace android
 }  // namespace net
 
-#endif  // NET_ANDROID_KEYSTORE_OPENSSL_H
+#endif  // NET_ANDROID_KEYSTORE_IMPL_H