service worker: Add UMA for start status grouped by start purpose.

service worker: Add UMA for start status grouped by start purpose.

Mostly for debugging bug 600226, but it's useful beyond that.

BUG=600226
Committed: https://crrev.com/84d425e0db07b37475a7cb467fec6f0fca41dc6d
Cr-Commit-Position: refs/heads/master@{#389993}

[falken, 2016-04-25 05:45:59]

falken@chromium.org changed reviewers:
+ nhiroki@chromium.org

[falken, 2016-04-25 05:46:00]

ptal

[falken, 2016-04-25 15:26:16]

falken@chromium.org changed reviewers:
+ jwd@chromium.org

[falken, 2016-04-25 15:26:16]

jwd: Could you review this please?

[jwd, 2016-04-25 19:10:49]

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:47590: +<histogram
name="ServiceWorker.StartWorker.StatusByPurpose"
Note, you could have reused ServiceWorker.StartWorker.Status as the base for
these suffixes, but this it's fine how it is too.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:47595: +    Only recorded for installed
workers. For event type:
Can you mention ServiceWorker.StartWorker.Status as a total for these, and add
to ServiceWorker.StartWorker.Status' description to mention this breakdown.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93026: +  <affected-histogram
name="ServiceWorker.StartWorker.StatusByPurpose"/>
nit: put this at the end of histogram_suffixes.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93027: +  <suffix name="ACTIVATE"/>
You need to add a label to these for anything to be appended to the histogram
summary.

[falken, 2016-04-26 01:44:45]

Thanks, revised.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:47590: +<histogram
name="ServiceWorker.StartWorker.StatusByPurpose"
On 2016/04/25 19:10:49, Jesse Doherty wrote:
> Note, you could have reused ServiceWorker.StartWorker.Status as the base for
> these suffixes, but this it's fine how it is too.

Acknowledged.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:47595: +    Only recorded for installed
workers. For event type:
On 2016/04/25 19:10:49, Jesse Doherty wrote:
> Can you mention ServiceWorker.StartWorker.Status as a total for these, and add
> to ServiceWorker.StartWorker.Status' description to mention this breakdown.

Done.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93026: +  <affected-histogram
name="ServiceWorker.StartWorker.StatusByPurpose"/>
On 2016/04/25 19:10:49, Jesse Doherty wrote:
> nit: put this at the end of histogram_suffixes.

Done.

https://codereview.chromium.org/1921503003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:93027: +  <suffix name="ACTIVATE"/>
On 2016/04/25 19:10:49, Jesse Doherty wrote:
> You need to add a label to these for anything to be appended to the histogram
> summary.

Ahh good point. The labels are kind of silly but I added it so the description
makes sense.

[nhiroki, 2016-04-26 06:05:20]

lgtm

https://codereview.chromium.org/1921503003/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.h (right):

https://codereview.chromium.org/1921503003/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_metrics.h:88: //
SERVICE_PORT_CONNECT = 7,
DEPRECATED_SERVICE_PORT_CONNECT?

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:47597: +    installed workers. For event
type:
"For event type:"

Did you forgot to remove this?

[falken, 2016-04-26 06:11:20]

Updated.

https://codereview.chromium.org/1921503003/diff/40001/content/browser/service...
File content/browser/service_worker/service_worker_metrics.h (right):

https://codereview.chromium.org/1921503003/diff/40001/content/browser/service...
content/browser/service_worker/service_worker_metrics.h:88: //
SERVICE_PORT_CONNECT = 7,
On 2016/04/26 06:05:20, nhiroki wrote:
> DEPRECATED_SERVICE_PORT_CONNECT?

Right, I guess it should be consistent with above. I changed these to have an //
Obsolete comment.

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:47597: +    installed workers. For event
type:
On 2016/04/26 06:05:20, nhiroki wrote:
> "For event type:"
> 
> Did you forgot to remove this?

No, the label from the <suffix> tag is appended here.

[nhiroki, 2016-04-26 06:23:19]

Does last-controllee.html relate to this CL?

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1921503003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:47597: +    installed workers. For event
type:
On 2016/04/26 06:11:20, falken wrote:
> On 2016/04/26 06:05:20, nhiroki wrote:
> > "For event type:"
> > 
> > Did you forgot to remove this?
> 
> No, the label from the <suffix> tag is appended here.

I see. Thank you for the explanation :)

[falken, 2016-04-26 06:31:23]

Oops. Removed stray file.

[jwd, 2016-04-26 15:14:30]

lgtm

[falken, 2016-04-26 15:20:11]

The CQ bit was checked by falken@chromium.org

[falken, 2016-04-26 15:20:12]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1921503003/#ps80001
(title: "rm extraneous file")

[commit-bot: I haz the power, 2016-04-26 15:20:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503003/80001

[commit-bot: I haz the power, 2016-04-26 17:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 17:08:29]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[falken, 2016-04-27 03:29:36]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2016-04-27 03:29:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921503003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921503003/80001

[commit-bot: I haz the power, 2016-04-27 05:25:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-27 05:26:56]

Description was changed from

==========
service worker: Add UMA for start status grouped by start purpose.

Mostly for debugging bug 600226, but it's useful beyond that.

BUG=600226
==========

to

==========
service worker: Add UMA for start status grouped by start purpose.

Mostly for debugging bug 600226, but it's useful beyond that.

BUG=600226

Committed: https://crrev.com/84d425e0db07b37475a7cb467fec6f0fca41dc6d
Cr-Commit-Position: refs/heads/master@{#389993}
==========

[commit-bot: I haz the power, 2016-04-27 05:26:57]

Patchset 5 (id:??) landed as
https://crrev.com/84d425e0db07b37475a7cb467fec6f0fca41dc6d
Cr-Commit-Position: refs/heads/master@{#389993}