Chromium Code Reviews Chromium Code Reviews
Issue 1921503003:
service worker: Add UMA for start status grouped by start purpose. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 9cd4aeb73e09560882ebd20d2a86863eabbd7773..2f4333c5214565a20cf671fbb6f0f829ceb2b157 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -47587,6 +47587,15 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="ServiceWorker.StartWorker.StatusByPurpose" |
|
jwd
2016/04/25 19:10:49
Note, you could have reused ServiceWorker.StartWor
falken
2016/04/26 01:44:45
Acknowledged.
|
| + enum="ServiceWorkerStatusCode"> |
| + <owner>falken@chromium.org</owner> |
| + <summary> |
| + The result of trying to start a service worker for a particular event type. |
| + Only recorded for installed workers. For event type: |
|
jwd
2016/04/25 19:10:49
Can you mention ServiceWorker.StartWorker.Status a
falken
2016/04/26 01:44:44
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="ServiceWorker.StartWorker.Time" units="ms"> |
| <owner>falken@chromium.org</owner> |
| <summary> |
| @@ -83478,12 +83487,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <enum name="ServiceWorkerMetrics.EventType" type="int"> |
| <int value="0" label="ACTIVATE"/> |
| <int value="1" label="INSTALL"/> |
| - <int value="2" label="FETCH (deprecated)"/> |
| + <int value="2" label="FETCH (unused)"/> |
| <int value="3" label="SYNC"/> |
| <int value="4" label="NOTIFICATION_CLICK"/> |
| <int value="5" label="PUSH"/> |
| <int value="6" label="GEOFENCING"/> |
| - <int value="7" label="SERVICE_PORT_CONNECT"/> |
| + <int value="7" label="SERVICE_PORT_CONNECT (unused)"/> |
| <int value="8" label="MESSAGE"/> |
| <int value="9" label="NOTIFICATION_CLOSE"/> |
| <int value="10" label="FETCH_MAIN_FRAME"/> |
| @@ -93013,6 +93022,24 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <affected-histogram name="interstitial.interaction"/> |
| </histogram_suffixes> |
| +<histogram_suffixes name="ServiceWorker.EventType"> |
| + <affected-histogram name="ServiceWorker.StartWorker.StatusByPurpose"/> |
|
jwd
2016/04/25 19:10:49
nit: put this at the end of histogram_suffixes.
falken
2016/04/26 01:44:44
Done.
|
| + <suffix name="ACTIVATE"/> |
|
jwd
2016/04/25 19:10:49
You need to add a label to these for anything to b
falken
2016/04/26 01:44:44
Ahh good point. The labels are kind of silly but I
|
| + <suffix name="INSTALL"/> |
| + <suffix name="SYNC"/> |
| + <suffix name="NOTIFICATION_CLICK"/> |
| + <suffix name="PUSH"/> |
| + <suffix name="GEOFENCING"/> |
| + <suffix name="MESSAGE"/> |
| + <suffix name="NOTIFICATION_CLOSE"/> |
| + <suffix name="FETCH_MAIN_FRAME"/> |
| + <suffix name="FETCH_SUB_FRAME"/> |
| + <suffix name="FETCH_SHARED_WORKER"/> |
| + <suffix name="FETCH_SUB_RESOURCE"/> |
| + <suffix name="UNKNOWN"/> |
| + <suffix name="FOREIGN_FETCH"/> |
| +</histogram_suffixes> |
| + |
| <histogram_suffixes name="ServiceWorker.FailureStreak"> |
| <affected-histogram name="ServiceWorker.StartWorker.AfterFailureStreak"/> |
| <suffix name="1" label="Failed one time."/> |
