[Findit] Adding improved error detection to MonitorTryJobPipeline

appengine/findit/waterfall/try_job_error.py

Index: appengine/findit/waterfall/try_job_error.py
diff --git a/appengine/findit/waterfall/try_job_error.py b/appengine/findit/waterfall/try_job_error.py
new file mode 100644
index 0000000000000000000000000000000000000000..f56b78bb44b4a0931330f8b7d68c682abb90cf23
--- /dev/null
+++ b/appengine/findit/waterfall/try_job_error.py
@@ -0,0 +1,18 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.

[stgao, 2016/04/26 17:33:06]

hmm, as findit/model/wf_try_job_data.py might refer to the error code here, it
seems better to add this module in findit/common/waterfall.
What your thought on leaving it here?

[lijeffrey, 2016/04/26 19:07:25]

I think you're right, common/waterfall is actually better

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Represents possible error codes for what can go wrong during try jobs."""
+
+# An error was detected but the root cause unknown. Cases resulting in this
+# should be investigated individually and common root causes added to this
+# module as dedicated error codes.
+UNKNOWN = 10
+# The try job did not finish within the required time and was was abandoned.

[stgao, 2016/04/26 17:33:07]

typo: 'was was'

[lijeffrey, 2016/04/26 19:07:25]

Done.

+TIMEOUT = 20
+# An error was returned directly when making a request buildbucket.
+BUILDBUCKET_REQUEST_ERROR = 30
+# Buildbucket ran the try job and reported an error.
+BUILDBUCKET_REPORTED_ERROR = 40
+# An infra failure occurred according to the recipe report.
+INFRA_FAILURE = 50