appengine/findit/waterfall/try_job_error.py - Issue 1921493002: [Findit] Adding improved error detection to MonitorTryJobPipeline

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/waterfall/try_job_error.py

Issue 1921493002: [Findit] Adding improved error detection to MonitorTryJobPipeline (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Addressing comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.
	stgao 2016/04/26 17:33:06 hmm, as findit/model/wf_try_job_data.py might refe hmm, as findit/model/wf_try_job_data.py might refer to the error code here, it seems better to add this module in findit/common/waterfall. What your thought on leaving it here? lijeffrey 2016/04/26 19:07:25 I think you're right, common/waterfall is actually Show quoted text On 2016/04/26 17:33:06, stgao wrote: > hmm, as findit/model/wf_try_job_data.py might refer to the error code here, it > seems better to add this module in findit/common/waterfall. > What your thought on leaving it here? I think you're right, common/waterfall is actually better
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """Represents possible error codes for what can go wrong during try jobs."""

	6

	7 # An error was detected but the root cause unknown. Cases resulting in this

	8 # should be investigated individually and common root causes added to this

	9 # module as dedicated error codes.

	10 UNKNOWN = 10

	11 # The try job did not finish within the required time and was was abandoned.
	stgao 2016/04/26 17:33:07 typo: 'was was' typo: 'was was' lijeffrey 2016/04/26 19:07:25 Done. Show quoted text On 2016/04/26 17:33:07, stgao wrote: > typo: 'was was' Done.
	12 TIMEOUT = 20

	13 # An error was returned directly when making a request buildbucket.

	14 BUILDBUCKET_REQUEST_ERROR = 30

	15 # Buildbucket ran the try job and reported an error.

	16 BUILDBUCKET_REPORTED_ERROR = 40

	17 # An infra failure occurred according to the recipe report.

	18 INFRA_FAILURE = 50

OLD	NEW

« appengine/findit/waterfall/monitor_try_job_pipeline.py ('K') | « appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py ('k') | no next file » | no next file with comments »