Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192133002: Use isSVG*Element() helpers more in SVG code (Part 1) (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis
Visibility:
Public.

Description

Use isSVG*Element() helpers more in SVG code (Part 1) Use isSVG*Element() helpers more in SVG code. Also use the Traversal<SVG*Element> API where suitable. This makes the code clearer / simpler. R=pdr BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -93 lines) Patch
M Source/core/svg/SVGAltGlyphDefElement.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAltGlyphElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M Source/core/svg/SVGDocument.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGElement.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGFEComponentTransferElement.cpp View 2 chunks +11 lines, -10 lines 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFontElement.cpp View 3 chunks +14 lines, -18 lines 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFontFaceFormatElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGFontFaceSrcElement.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M Source/core/svg/SVGFontFaceUriElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-03-09 01:13:26 UTC) #1
pdr.
On 2014/03/09 01:13:26, Chris Dumez wrote: LGTM
6 years, 9 months ago (2014-03-09 02:16:10 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-09 02:16:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/192133002/1
6 years, 9 months ago (2014-03-09 02:16:30 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 02:24:20 UTC) #5
Message was sent while issue was closed. 
Change committed as 168796

Powered by Google App Engine
This is Rietveld 408576698