Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1921263002: Manually rebaseline hidpi tests (Closed)

Created:
4 years, 8 months ago by davve
Modified:
4 years, 8 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manually rebaseline hidpi tests The following pixel tests needed rebaselining after switch from quirks mode to standards mode in r389730: fast/hidpi/broken-image-icon-hidpi.html fast/hidpi/image-srcset-invalid-descriptor.html fast/hidpi/resize-corner-hidpi.html fast/hidpi/broken-image-with-size-hidpi.html fast/hidpi/video-controls-in-hidpi.html fast/hidpi/focus-rings.html fast/hidpi/clip-text-in-hidpi.html fast/hidpi/image-set-as-background-with-zoom.html fast/hidpi/gradient-with-scaled-ancestor.html TBR=yoav@yoav.ws BUG=605065 Committed: https://crrev.com/4faf085b2363429f21067ddb714219daba2f00c1 Cr-Commit-Position: refs/heads/master@{#389758}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -85 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/focus-rings-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/broken-image-icon-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/broken-image-with-size-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/clip-text-in-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/focus-rings-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/gradient-with-scaled-ancestor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/image-set-as-background-with-zoom-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/image-srcset-invalid-descriptor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/resize-corner-hidpi-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/resize-corner-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/android/fast/hidpi/video-controls-in-hidpi-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt View 1 chunk +6 lines, -5 lines 2 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-with-size-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/clip-text-in-hidpi-expected.txt View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/image-set-as-background-with-zoom-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/resize-corner-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/resize-corner-hidpi-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/video-controls-in-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/hidpi/resize-corner-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/clip-text-in-hidpi-expected.txt View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/image-set-as-background-with-zoom-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/broken-image-icon-hidpi-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/broken-image-with-size-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/clip-text-in-hidpi-expected.txt View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/image-set-as-background-with-zoom-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/resize-corner-hidpi-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/resize-corner-hidpi-expected.txt View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/hidpi/video-controls-in-hidpi-expected.txt View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921263002/1
4 years, 8 months ago (2016-04-26 11:45:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 12:48:59 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4faf085b2363429f21067ddb714219daba2f00c1 Cr-Commit-Position: refs/heads/master@{#389758}
4 years, 8 months ago (2016-04-26 12:50:15 UTC) #5
Yoav Weiss
https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt File third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt (right): https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt#newcode4 third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt:4: LayoutBlockFlow {HTML} at (0,0) size 800x61 Do you know ...
4 years, 8 months ago (2016-04-26 13:19:22 UTC) #6
davve
https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt File third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt (right): https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt#newcode4 third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt:4: LayoutBlockFlow {HTML} at (0,0) size 800x61 On 2016/04/26 13:19:22, ...
4 years, 8 months ago (2016-04-26 14:02:05 UTC) #7
Yoav Weiss
4 years, 8 months ago (2016-04-26 16:36:23 UTC) #8
Message was sent while issue was closed. 
On 2016/04/26 14:02:05, David Vest wrote:
>
https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt
> (right):
> 
>
https://codereview.chromium.org/1921263002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt:4:
> LayoutBlockFlow {HTML} at (0,0) size 800x61
> On 2016/04/26 13:19:22, Yoav Weiss wrote:
> > Do you know why the height is significantly lower now? Didn't the change
just
> > refactor the tests?
> 
> It's a quirks-mode thing in Blink (highly likely to be inherited from WebKit
but
> I can't verify) that body and html element gets the height from the viewport.
> 
> Compare
> 
> <style>
> html { border: 10px dashed black; }
> </style>
> 
> with
> 
> <!DOCTYPE html>
> <style>
> html { border: 10px dashed black; }
> </style>
> 
> in something Blink-based. Firefox doesn't seem to have this quirk and it's not
> present in the quirks spec, AFAICT.

Cool. LGTM

Powered by Google App Engine
This is Rietveld 408576698