third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt - Issue 1921263002: Manually rebaseline hidpi tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-icon-hidpi-expected.txt

Issue 1921263002: Manually rebaseline hidpi tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/android/fast/hidpi/video-controls-in-hidpi-expected.txt ('k') | third_party/WebKit/LayoutTests/platform/linux/fast/hidpi/broken-image-with-size-hidpi-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 layer at (0,0) size 800x600	1 layer at (0,0) size 800x600

2 LayoutView at (0,0) size 800x600	2 LayoutView at (0,0) size 800x600

3 layer at (0,0) size 800x600	3 layer at (0,0) size 800x61

4 LayoutBlockFlow {HTML} at (0,0) size 800x600	4 LayoutBlockFlow {HTML} at (0,0) size 800x61
	Yoav Weiss 2016/04/26 13:19:22 Do you know why the height is significantly lower Do you know why the height is significantly lower now? Didn't the change just refactor the tests? davve 2016/04/26 14:02:05 It's a quirks-mode thing in Blink (highly likely t Show quoted text On 2016/04/26 13:19:22, Yoav Weiss wrote: > Do you know why the height is significantly lower now? Didn't the change just > refactor the tests? It's a quirks-mode thing in Blink (highly likely to be inherited from WebKit but I can't verify) that body and html element gets the height from the viewport. Compare <style> html { border: 10px dashed black; } </style> with <!DOCTYPE html> <style> html { border: 10px dashed black; } </style> in something Blink-based. Firefox doesn't seem to have this quirk and it's not present in the quirks spec, AFAICT.
5 LayoutBlockFlow {BODY} at (8,8) size 784x584	5 LayoutBlockFlow {BODY} at (8,8) size 784x45

6 LayoutBlockFlow {DIV} at (0,0) size 784x20	6 LayoutBlockFlow {DIV} at (0,0) size 784x20

7 LayoutText {#text} at (0,0) size 700x19	7 LayoutText {#text} at (0,0) size 700x19

8 text run at (0,0) width 700: "This test passes if the broken image ico n appears high-resolution in HiDPI and if the outline is of the appropriate size ."	8 text run at (0,0) width 700: "This test passes if the broken image ico n appears high-resolution in HiDPI and if the outline is of the appropriate size ."

9 LayoutBlockFlow (anonymous) at (0,20) size 784x20	9 LayoutBlockFlow (anonymous) at (0,20) size 784x25

10 LayoutBlockFlow {IMG} at (0,0) size 20x20	10 LayoutBlockFlow {IMG} at (0,0) size 20x25

	11 LayoutText {#text} at (0,0) size 0x0

11 LayoutText {#text} at (0,0) size 0x0	12 LayoutText {#text} at (0,0) size 0x0

12 layer at (8,28) size 20x20 clip at (9,29) size 18x18	13 layer at (8,28) size 20x20 clip at (9,29) size 18x18

13 LayoutBlockFlow {DIV} at (0,0) size 20x20 [border: (1px solid #C0C0C0)]	14 LayoutBlockFlow {DIV} at (0,0) size 20x20 [border: (1px solid #C0C0C0)]

14 LayoutImage (floating) {IMG} at (2,2) size 16x16	15 LayoutImage (floating) {IMG} at (2,2) size 16x16

15 layer at (26,30) size 0x0	16 layer at (26,30) size 0x0

16 LayoutBlockFlow {DIV} at (18,2) size 0x0	17 LayoutBlockFlow {DIV} at (18,2) size 0x0

OLD	NEW