Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1921213005: Only overwrite DomKey of keydown event if it's a printable character (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Only overwrite DomKey of keydown event if it's a printable character InputMethodWin will combine the WM_KEY* and WM_CHAR messages, and will overwrite DomKey for |keydown| with the DomKey of |keypress|. We want to only overwite it if the new DomKey is not a control character. BUG=601882 Review URL: https://codereview.chromium.org/1875763003 Cr-Commit-Position: refs/heads/master@{#386691} (cherry picked from commit 19ec26442db050a055cf9f9486aa69db4bd70cf1) Committed: https://chromium.googlesource.com/chromium/src/+/ebe05dfa595ef8688ff8f10eac850821ed095de2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/base/ime/input_method_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dtapuska
4 years, 7 months ago (2016-04-27 16:20:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ebe05dfa595ef8688ff8f10eac850821ed095de2.

Powered by Google App Engine
This is Rietveld 408576698