Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1875763003: Only overwrite DomKey of keydown event if it's a printable character (Closed)

Created:
4 years, 8 months ago by chongz
Modified:
4 years, 8 months ago
Reviewers:
Shu Chen, dtapuska
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, Azure Wei
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only overwrite DomKey of keydown event if it's a printable character InputMethodWin will combine the WM_KEY* and WM_CHAR messages, and will overwrite DomKey for |keydown| with the DomKey of |keypress|. We want to only overwite it if the new DomKey is not a control character. BUG=601882 Committed: https://crrev.com/19ec26442db050a055cf9f9486aa69db4bd70cf1 Cr-Commit-Position: refs/heads/master@{#386691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/base/ime/input_method_win.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
chongz
I'm not sure what IME is expecting... PTAL, thanks!
4 years, 8 months ago (2016-04-08 19:29:41 UTC) #2
Shu Chen
lgtm
4 years, 8 months ago (2016-04-11 21:00:04 UTC) #3
Shu Chen
CC'ing azurewei@ who may have met the similar issue.
4 years, 8 months ago (2016-04-11 21:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875763003/1
4 years, 8 months ago (2016-04-12 14:17:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 15:27:07 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 15:27:58 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19ec26442db050a055cf9f9486aa69db4bd70cf1
Cr-Commit-Position: refs/heads/master@{#386691}

Powered by Google App Engine
This is Rietveld 408576698