Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory …

Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/117a56b7c2a88ab2b2f25fad88517d72f5edbac9
Cr-Commit-Position: refs/heads/master@{#36044}

[gdeepti, 2016-04-26 08:09:36]

https://codereview.chromium.org/1921203002/diff/1/src/assembler.h
File src/assembler.h (right):

https://codereview.chromium.org/1921203002/diff/1/src/assembler.h#newcode389
src/assembler.h:389: WASM_MEMORY_SIZE_REFERENCE,
Removing wasm RelocInfo modes from the shareable relocation modes list for now
as this causes multiple updates to the same constants in the constant pool in
some cases on Arm, fix in progress.

[gdeepti, 2016-04-26 17:30:31]

Description was changed from

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

BUG=NONE

R=titzer@chromium.org, yanguo@chromium.org, bradnelson@chromium.org
==========

to

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

BUG=NONE

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

[gdeepti, 2016-04-26 17:30:31]

gdeepti@chromium.org changed reviewers:
+ yangguo@chromium.org
- yanguo@chromium.org

[titzer, 2016-04-28 11:40:19]

https://codereview.chromium.org/1921203002/diff/20001/src/arm/assembler-arm-i...
File src/arm/assembler-arm-inl.h (right):

https://codereview.chromium.org/1921203002/diff/20001/src/arm/assembler-arm-i...
src/arm/assembler-arm-inl.h:127: Address old_base, Address new_base, int32_t
old_size, int32_t new_size,
Let's use uint32_t here and elsewhere.

https://codereview.chromium.org/1921203002/diff/20001/src/compiler/arm64/code...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1921203002/diff/20001/src/compiler/arm64/code...
src/compiler/arm64/code-generator-arm64.cc:193: constant.rmode() ==
RelocInfo::WASM_MEMORY_SIZE_REFERENCE) {
I think we are limiting ourselves to 32 bit sizes now, so we can drop this case
(or even better, have a DCHECK). Here and in the other 64-bit code generators.

[gdeepti, 2016-05-02 22:45:12]

Description was changed from

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

BUG=NONE

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

to

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

[gdeepti, 2016-05-02 23:56:09]

https://codereview.chromium.org/1921203002/diff/20001/src/arm/assembler-arm-i...
File src/arm/assembler-arm-inl.h (right):

https://codereview.chromium.org/1921203002/diff/20001/src/arm/assembler-arm-i...
src/arm/assembler-arm-inl.h:127: Address old_base, Address new_base, int32_t
old_size, int32_t new_size,
On 2016/04/28 11:40:19, titzer wrote:
> Let's use uint32_t here and elsewhere.

Done.

https://codereview.chromium.org/1921203002/diff/20001/src/compiler/arm64/code...
File src/compiler/arm64/code-generator-arm64.cc (right):

https://codereview.chromium.org/1921203002/diff/20001/src/compiler/arm64/code...
src/compiler/arm64/code-generator-arm64.cc:193: constant.rmode() ==
RelocInfo::WASM_MEMORY_SIZE_REFERENCE) {
On 2016/04/28 11:40:19, titzer wrote:
> I think we are limiting ourselves to 32 bit sizes now, so we can drop this
case
> (or even better, have a DCHECK). Here and in the other 64-bit code generators.

Dropped, and added a DCHECK for x64 & Arm64. There was a bug in the constructor
for RelocatablePtrConstantInfo which was causing relocatable int32 constants to
be treated as int64 constants. This was happening only on arm64 because x64 uses
the Immediates vector in compiler/instruction.h for adding/retrieving immediates
and does not use the constructor. Fixed now.

[titzer, 2016-05-04 11:21:23]

lgtm other than below comments

https://codereview.chromium.org/1921203002/diff/80001/src/arm/assembler-arm-i...
File src/arm/assembler-arm-inl.h (right):

https://codereview.chromium.org/1921203002/diff/80001/src/arm/assembler-arm-i...
src/arm/assembler-arm-inl.h:126: void RelocInfo::update_wasm_memory_reference(
Can we move this into the .cc file? There are other big methods here, but I
think this isn't performance critical enough to warrant being in the -inl.h
file.

Here and in the other architectures as well.

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
src/compiler/common-operator.cc:702:
RelocatablePtrConstantInfo(static_cast<int32_t>(value),
AFAICT, the static_cast here is unnecessary.

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
src/compiler/common-operator.cc:712:
RelocatablePtrConstantInfo(static_cast<int64_t>(value),
Here as well.

[gdeepti, 2016-05-04 20:14:52]

https://codereview.chromium.org/1921203002/diff/80001/src/arm/assembler-arm-i...
File src/arm/assembler-arm-inl.h (right):

https://codereview.chromium.org/1921203002/diff/80001/src/arm/assembler-arm-i...
src/arm/assembler-arm-inl.h:126: void RelocInfo::update_wasm_memory_reference(
On 2016/05/04 11:21:22, titzer wrote:
> Can we move this into the .cc file? There are other big methods here, but I
> think this isn't performance critical enough to warrant being in the -inl.h
> file.
> 
> Here and in the other architectures as well.

Done.

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
File src/compiler/common-operator.cc (right):

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
src/compiler/common-operator.cc:702:
RelocatablePtrConstantInfo(static_cast<int32_t>(value),
On 2016/05/04 11:21:22, titzer wrote:
> AFAICT, the static_cast here is unnecessary.

Done.

https://codereview.chromium.org/1921203002/diff/80001/src/compiler/common-ope...
src/compiler/common-operator.cc:712:
RelocatablePtrConstantInfo(static_cast<int64_t>(value),
On 2016/05/04 11:21:22, titzer wrote:
> Here as well.

Done.

[gdeepti, 2016-05-04 20:15:02]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2016-05-04 20:15:03]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1921203002/#ps100001
(title: "Ben's review")

[commit-bot: I haz the power, 2016-05-04 20:15:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1921203002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1921203002/100001

[commit-bot: I haz the power, 2016-05-04 20:19:33]

Description was changed from

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

to

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

[commit-bot: I haz the power, 2016-05-04 20:19:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-04 20:21:01]

Description was changed from

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org
==========

to

==========
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to
update wasm memory size references in generated code.
 - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add
relocation information to immediates in compare instructions.
 - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler

R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org

Committed: https://crrev.com/117a56b7c2a88ab2b2f25fad88517d72f5edbac9
Cr-Commit-Position: refs/heads/master@{#36044}
==========

[commit-bot: I haz the power, 2016-05-04 20:21:02]

Patchset 6 (id:??) landed as
https://crrev.com/117a56b7c2a88ab2b2f25fad88517d72f5edbac9
Cr-Commit-Position: refs/heads/master@{#36044}