src/compiler/arm/code-generator-arm.cc - Issue 1921203002: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 1921203002: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Ben's review Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm/code-generator-arm.cc

diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc

index b7d92930987e833a2476bd300ba100197630dc49..692b96553559a7882ff54e3897413578f5903213 100644

--- a/src/compiler/arm/code-generator-arm.cc

+++ b/src/compiler/arm/code-generator-arm.cc

@@ -1520,7 +1520,8 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,

destination->IsRegister() ? g.ToRegister(destination) : kScratchReg;

switch (src.type()) {

case Constant::kInt32:

- if (src.rmode() == RelocInfo::WASM_MEMORY_REFERENCE) {

+ if (src.rmode() == RelocInfo::WASM_MEMORY_REFERENCE ||

+ src.rmode() == RelocInfo::WASM_MEMORY_SIZE_REFERENCE) {

__ mov(dst, Operand(src.ToInt32(), src.rmode()));

} else {

__ mov(dst, Operand(src.ToInt32()));

« no previous file with comments | « src/assembler.cc ('k') | src/compiler/arm64/code-generator-arm64.cc » ('j') | no next file with comments »