Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1921073003: S390X: [turbofan] Fix checked loads/stores. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390X: [turbofan] Fix checked loads/stores. This refines 6382a61059daf167511a224f8760a23473812de6 -- as we still require clean up of the uint index register. TEST=mjsunit/asm/float32array-negative-offset R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Conflicts: src/compiler/s390/code-generator-s390.cc Committed: https://crrev.com/3e9924f6ddc2af8d32bd0f1391b50c5e8891b4ae Cr-Commit-Position: refs/heads/master@{#35879}

Patch Set 1 #

Patch Set 2 : rebase on master #

Total comments: 1

Patch Set 3 : use macroassembler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 2 5 chunks +5 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-26 13:56:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921073003/1
4 years, 8 months ago (2016-04-26 16:48:20 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/757)
4 years, 8 months ago (2016-04-26 16:53:51 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921073003/20001
4 years, 8 months ago (2016-04-26 18:32:58 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-26 18:56:49 UTC) #9
JoranSiu
https://codereview.chromium.org/1921073003/diff/20001/src/compiler/s390/code-generator-s390.cc File src/compiler/s390/code-generator-s390.cc (right): https://codereview.chromium.org/1921073003/diff/20001/src/compiler/s390/code-generator-s390.cc#newcode455 src/compiler/s390/code-generator-s390.cc:455: #if V8_TARGET_ARCH_S390X Should we make this in macro asm?
4 years, 8 months ago (2016-04-26 20:37:48 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921073003/40001
4 years, 7 months ago (2016-04-28 19:05:08 UTC) #12
JoranSiu
On 2016/04/28 19:05:08, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 7 months ago (2016-04-28 19:14:36 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 19:25:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921073003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921073003/40001
4 years, 7 months ago (2016-04-28 19:40:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 19:43:38 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:58 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3e9924f6ddc2af8d32bd0f1391b50c5e8891b4ae
Cr-Commit-Position: refs/heads/master@{#35879}

Powered by Google App Engine
This is Rietveld 408576698