Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1921003009: Revert of Use GN in simple chrome builders (Closed)

Created:
4 years, 7 months ago by Dirk Pranke
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use GN in simple chrome builders (patchset #1 id:1 of https://codereview.chromium.org/1918713005/ ) Reason for revert: Well, I fixed a bunch of things, but it got late and I'm still hitting bugs, so I'm going to try to flip this back to GYP and see if that works, at least (through MB). https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20amd64-generic%20Compile/builds/17407 The last error makes it look like we might be missing a few targets that chromiumos_preflight needs, but I might've also just gotten the build labels wrong in the GN build. I suggest we try again tomorrow and flip the trybots at the same time so we can be consistent and see the trybots working first. Original issue's description: > Use GN in simple chrome builders > > BUG=605154 > > Committed: https://crrev.com/78685fb274d05ee48e5425dc2ce4f5ba7b2dce81 > Cr-Commit-Position: refs/heads/master@{#389914} TBR=stevenjb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=605154 Committed: https://crrev.com/570d6f823fd119974967652479bf570e5002a362 Cr-Commit-Position: refs/heads/master@{#389998}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of Use GN in simple chrome builders
4 years, 7 months ago (2016-04-27 06:06:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1921003009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1921003009/1
4 years, 7 months ago (2016-04-27 06:06:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-27 06:07:34 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 06:08:35 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/570d6f823fd119974967652479bf570e5002a362
Cr-Commit-Position: refs/heads/master@{#389998}

Powered by Google App Engine
This is Rietveld 408576698