Use GN in simple chrome builders

Use GN in simple chrome builders

BUG=605154
Committed: https://crrev.com/78685fb274d05ee48e5425dc2ce4f5ba7b2dce81
Cr-Commit-Position: refs/heads/master@{#389914}

[stevenjb, 2016-04-26 19:56:11]

stevenjb@chromium.org changed reviewers:
+ dpranke@chromium.org

[stevenjb, 2016-04-26 19:56:12]

Is this the correct change to switch the simple chrome builders to use GN?

I just confirmed that GN config is working for Simple Chrome again in ToT (at
least with x86-generic, amd64-generic, and daisy).

We are ready to switch these over any time. Thanks!

[Dirk Pranke, 2016-04-26 20:14:59]

yup, that's the right change. however, I suggest we just flip one bot for now to
see if the integration works and then flip the other two if it does.

[stevenjb, 2016-04-26 20:48:37]

I was going to do that originally, but at this point I would rather flip
all three at once.

I am pretty certain that the only people that look at those builders
currently are myself and maybe the gardeners (who I will warn).

We should definitely wait a bit for these to run before flipping the
tryservers however.


On Tue, Apr 26, 2016 at 2:14 PM, <dpranke@chromium.org> wrote:

> yup, that's the right change. however, I suggest we just flip one bot for
> now to
> see if the integration works and then flip the other two if it does.
>
> https://codereview.chromium.org/1918713005/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dirk Pranke, 2016-04-26 20:53:31]

Okay, I don't care much either way and am not afraid of breaking things.
I'll keep an eye on it as it lands, too.

lgtm.

On Tue, Apr 26, 2016 at 1:48 PM, Steven Bennetts <stevenjb@chromium.org>
wrote:

> I was going to do that originally, but at this point I would rather flip
> all three at once.
>
> I am pretty certain that the only people that look at those builders
> currently are myself and maybe the gardeners (who I will warn).
>
> We should definitely wait a bit for these to run before flipping the
> tryservers however.
>
>
> On Tue, Apr 26, 2016 at 2:14 PM, <dpranke@chromium.org> wrote:
>
>> yup, that's the right change. however, I suggest we just flip one bot for
>> now to
>> see if the integration works and then flip the other two if it does.
>>
>> https://codereview.chromium.org/1918713005/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stevenjb, 2016-04-26 20:53:57]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:54:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918713005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918713005/1

[commit-bot: I haz the power, 2016-04-26 20:54:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:54:25]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2016-04-26 20:55:41]

lgtm ??

[Dirk Pranke, 2016-04-26 20:55:48]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2016-04-26 20:56:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918713005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918713005/1

[commit-bot: I haz the power, 2016-04-26 22:18:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 22:19:47]

Description was changed from

==========
Use GN in simple chrome builders

BUG=605154
==========

to

==========
Use GN in simple chrome builders

BUG=605154

Committed: https://crrev.com/78685fb274d05ee48e5425dc2ce4f5ba7b2dce81
Cr-Commit-Position: refs/heads/master@{#389914}
==========

[commit-bot: I haz the power, 2016-04-26 22:19:51]

Patchset 1 (id:??) landed as
https://crrev.com/78685fb274d05ee48e5425dc2ce4f5ba7b2dce81
Cr-Commit-Position: refs/heads/master@{#389914}

[Dirk Pranke, 2016-04-27 06:06:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1921003009/ by dpranke@chromium.org.

The reason for reverting is: Well, I fixed a bunch of things, but it got late
and I'm still hitting bugs, so I'm going to try to flip this back to GYP and see
if that works, at least (through MB).

https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20amd64-...

The last error makes it look like we might be missing a few targets that
chromiumos_preflight needs, but I might've also just gotten the build labels
wrong in the GN build.

I suggest we try again tomorrow and flip the trybots at the same time so we can
be consistent and see the trybots working first..