Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1920873002: Enable error pages for layout tests. (Closed)

Created:
4 years, 8 months ago by Mike West
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable error pages for layout tests. Currently, we remove error page navigation for layout tests, which means that we have strangely divergent behavior in some edge cases. This patch removes that special-casing and fixes up tests that depended on the edge cases. Committed: https://crrev.com/76a6a7e22ef2c2b0807b9f6e903778c453cd0ffb Cr-Commit-Position: refs/heads/master@{#390625}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : Ugh. #

Patch Set 4 : Ugh. #

Patch Set 5 : NO_COPIES #

Patch Set 6 : Tests. #

Patch Set 7 : Ugh? #

Patch Set 8 : TEST. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -290 lines) Patch
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-assign-crash.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-assign-crash-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-href-put-crash.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-href-put-crash-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-put-crash.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-put-crash-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-replace-crash.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-location-replace-crash-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-window-open-crash.html View 1 2 3 4 5 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/null-document-window-open-crash-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/xmlhttprequest/null-document-xmlhttprequest-open.html View 1 2 3 4 5 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/xmlhttprequest/null-document-xmlhttprequest-open-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/loading/bad-server-subframe-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-frame-resource.html View 1 2 3 2 chunks +17 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-request-redirect.html View 1 2 3 4 1 chunk +8 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-1.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-1-expected.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-1.html View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-1-expected.html View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-2.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-2-expected.html View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/010-expected.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/editing/focus/document-level-focus-apis/test.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/editing/focus/document-level-focus-apis/test-expected.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/selectors/pseudo-classes/focus-iframe-expected.html View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents.html View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-source-lines-inline.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Mike West
WDYT, Jochen? Checking for layout-testness up here doesn't make much sense regardless, but perhaps you ...
4 years, 8 months ago (2016-04-25 15:01:53 UTC) #2
jochen (gone - plz use gerrit)
On 2016/04/25 at 15:01:53, mkwst wrote: > WDYT, Jochen? Checking for layout-testness up here doesn't ...
4 years, 8 months ago (2016-04-25 15:56:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920873002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920873002/100001
4 years, 7 months ago (2016-04-27 11:48:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/218224)
4 years, 7 months ago (2016-04-27 13:17:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920873002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920873002/140001
4 years, 7 months ago (2016-04-29 10:48:54 UTC) #11
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 7 months ago (2016-04-29 12:09:10 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:25:14 UTC) #13
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/76a6a7e22ef2c2b0807b9f6e903778c453cd0ffb
Cr-Commit-Position: refs/heads/master@{#390625}

Powered by Google App Engine
This is Rietveld 408576698