Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1920863005: Disable autoplay experiments if the autoplay content settings is set to block. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@autoplay-ifsameorigin-ormuted
Patch Set: split autoplay experiment tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 8beea08cbcdda8e7b55f8d57890f68315abf9bed..55a5e6dfaeb74673babd005f4899a266a2092ea0 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -324,6 +324,8 @@ public:
return frame && frame->isCrossOrigin();
}
+ bool isAutoplayAllowedPerSettings() const override;
+
// LayoutObject
void setRequestPositionUpdates(bool) override;
IntRect absoluteBoundingBoxRect() const override;
@@ -3840,6 +3842,15 @@ String HTMLMediaElement::AutoplayHelperClientImpl::autoplayExperimentMode() cons
return mode;
}
+bool HTMLMediaElement::AutoplayHelperClientImpl::isAutoplayAllowedPerSettings() const
+{
+ LocalFrame* frame = m_element->document().frame();
+ if (!frame)
+ return false;
+ FrameLoaderClient* frameLoaderClient = frame->loader().client();
+ return frameLoaderClient && frameLoaderClient->allowAutoplay(false);
+}
+
void HTMLMediaElement::AutoplayHelperClientImpl::setRequestPositionUpdates(bool request)
{
if (LayoutObject* layoutObject = m_element->layoutObject()) {

Powered by Google App Engine
This is Rietveld 408576698