Issue 1920793005: Merge to M51: Cloud Print Proxy: Delete print jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1920793005: Merge to M51: Cloud Print Proxy: Delete print jobs. (Closed)

Created:
4 years, 7 months ago by Lei Zhang

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Merge to M51: Cloud Print Proxy: Delete print jobs. There always exists some time window when the print job may not get deleted if the proxy crashes, but in general, print jobs will be deleted after they are spooled. Do some cleanups along the way. BUG=602736 Review URL: https://codereview.chromium.org/1907083002 Cr-Commit-Position: refs/heads/master@{#389354} (cherry picked from commit 8adc973dd3bd361b8b19f9e0f197cbf5737ddd06) Committed: https://chromium.googlesource.com/chromium/src/+/9881555842c9589c2f58c1c956cb7eada53fa4a5

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+105 lines, -98 lines)			Patch
M	chrome/service/cloud_print/print_system_cups.cc	View	3 chunks	+19 lines, -20 lines	0 comments	Download
M	chrome/service/cloud_print/print_system_win.cc	View	11 chunks	+59 lines, -40 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.h	View	6 chunks	+16 lines, -18 lines	0 comments	Download
M	chrome/service/cloud_print/printer_job_handler.cc	View	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/service/service_utility_process_host.cc	View	5 chunks	+4 lines, -13 lines	0 comments	Download

Total messages: 2 (1 generated)

Lei Zhang

4 years, 7 months ago (2016-04-25 20:45:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9881555842c9589c2f58c1c956cb7eada53fa4a5.