Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1907083002: Cloud Print Proxy: Delete print jobs. (Closed)

Created:
4 years, 8 months ago by Lei Zhang
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cloud Print Proxy: Delete print jobs. There always exists some time window when the print job may not get deleted if the proxy crashes, but in general, print jobs will be deleted after they are spooled. Do some cleanups along the way. BUG=602736 Committed: https://crrev.com/8adc973dd3bd361b8b19f9e0f197cbf5737ddd06 Cr-Commit-Position: refs/heads/master@{#389354}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -87 lines) Patch
M chrome/service/cloud_print/print_system_cups.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 11 chunks +55 lines, -36 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 6 chunks +16 lines, -18 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 5 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Lei Zhang
4 years, 8 months ago (2016-04-22 02:34:29 UTC) #8
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 8 months ago (2016-04-22 20:23:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907083002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907083002/100001
4 years, 8 months ago (2016-04-23 02:17:46 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 8 months ago (2016-04-23 03:34:17 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 03:35:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8adc973dd3bd361b8b19f9e0f197cbf5737ddd06
Cr-Commit-Position: refs/heads/master@{#389354}

Powered by Google App Engine
This is Rietveld 408576698