headless: Make it possible to override the DevTools server address

headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0 --remote-debugging-port=9222

Committed: https://crrev.com/a3559d964209644390fbfe905afd7f3e625674b1
Cr-Commit-Position: refs/heads/master@{#389743}

[Sami, 2016-04-25 14:49:01]

Description was changed from

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.
==========

to

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.
==========

[Sami, 2016-04-25 14:49:01]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org, mkwst@chromium.org

[Sami, 2016-04-25 14:49:38]

PTAL. The stated use case was to expose the debugging protocol from within a
docker container (which can't be done for a loopback address).

[Sami, 2016-04-25 14:51:26]

Description was changed from

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.
==========

to

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0
--remote-debugging-port=9222
==========

[Mike West, 2016-04-26 08:04:37]

Sanity checking aside, LGTM.

https://codereview.chromium.org/1920773003/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/1920773003/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:107:
headless::switches::kRemoteDebuggingAddress);
It seems reasonable to do some sanity checking here; maybe look at using
`net::ParseURLHostnameToAddress` to verify that the string you're given is
actually an IP address? Otherwise you'll potentially be in a bad state after the
call to assign the IP address to devtools below (the DCHECK wouldn't crash you
in non-debug mode).

[Sami, 2016-04-26 10:07:52]

https://codereview.chromium.org/1920773003/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/1920773003/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:107:
headless::switches::kRemoteDebuggingAddress);
On 2016/04/26 08:04:37, Mike West (slow until 25th) wrote:
> It seems reasonable to do some sanity checking here; maybe look at using
> `net::ParseURLHostnameToAddress` to verify that the string you're given is
> actually an IP address? Otherwise you'll potentially be in a bad state after
the
> call to assign the IP address to devtools below (the DCHECK wouldn't crash you
> in non-debug mode).

Good point. I've now made this use net::ParseURLHostnameToAddress and to bail
out if that doesn't like the input (plus the same for port parsing).

[Sami, 2016-04-26 10:07:55]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-04-26 10:07:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1920773003/#ps20001
(title: "Stricter hostname validation")

[commit-bot: I haz the power, 2016-04-26 10:08:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920773003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920773003/20001

[commit-bot: I haz the power, 2016-04-26 10:44:08]

Description was changed from

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0
--remote-debugging-port=9222
==========

to

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0
--remote-debugging-port=9222
==========

[commit-bot: I haz the power, 2016-04-26 10:44:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-26 10:45:19]

Description was changed from

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0
--remote-debugging-port=9222
==========

to

==========
headless: Make it possible to override the DevTools server address

Make it possible to override the address at which the DevTools server
accepts for incoming connections. This address is the loopback interface
by default, but with this switch it can be configured to be any IP
address.

TEST=headless_shell --remote-debugging-address=0.0.0.0
--remote-debugging-port=9222

Committed: https://crrev.com/a3559d964209644390fbfe905afd7f3e625674b1
Cr-Commit-Position: refs/heads/master@{#389743}
==========

[commit-bot: I haz the power, 2016-04-26 10:45:20]

Patchset 2 (id:??) landed as
https://crrev.com/a3559d964209644390fbfe905afd7f3e625674b1
Cr-Commit-Position: refs/heads/master@{#389743}