Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1920703002: [Fetch API] Fix leaky layout tests. (Closed)

Created:
4 years, 8 months ago by yhirano
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Fetch API] Fix leaky layout tests. Chrome implementation of Fetch API keep response alive while response.body is readable and locked by someone. This CL fix some layout tests to avoid leaks. See https://codereview.chromium.org/1899873006/ for more information. This CL also fixes 'acquiring a reader should not set bodyUsed' in stream-reader.js, because it was wrong but the assertion failure was caught and not reported. BUG=596832 Committed: https://crrev.com/40a9fad2888f2e0395aac0fa1eae7a7c1ac0e262 Cr-Commit-Position: refs/heads/master@{#389751}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js View 1 2 1 chunk +9 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (11 generated)
yhirano
4 years, 8 months ago (2016-04-25 02:27:44 UTC) #3
Yuki
https://codereview.chromium.org/1920703002/diff/20001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js (right): https://codereview.chromium.org/1920703002/diff/20001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js#newcode265 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js:265: // TODO: yhirano Use finally when it's available. Ditto ...
4 years, 8 months ago (2016-04-25 06:57:10 UTC) #5
yhirano
https://codereview.chromium.org/1920703002/diff/20001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js (right): https://codereview.chromium.org/1920703002/diff/20001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js#newcode265 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/body-mixin.js:265: // TODO: yhirano Use finally when it's available. Ditto ...
4 years, 8 months ago (2016-04-25 07:01:51 UTC) #6
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/1920703002/diff/40001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right): https://codereview.chromium.org/1920703002/diff/40001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js#newcode45 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:45: return res.text().then(unreached_rejection(t), function() { unreached_fulfillment
4 years, 7 months ago (2016-04-26 08:15:59 UTC) #11
yhirano
https://codereview.chromium.org/1920703002/diff/40001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js File third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right): https://codereview.chromium.org/1920703002/diff/40001/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js#newcode45 third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/stream-reader.js:45: return res.text().then(unreached_rejection(t), function() { On 2016/04/26 08:15:58, tyoshino wrote: ...
4 years, 7 months ago (2016-04-26 11:15:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920703002/60001
4 years, 7 months ago (2016-04-26 11:15:59 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-04-26 12:15:51 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 12:16:57 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/40a9fad2888f2e0395aac0fa1eae7a7c1ac0e262
Cr-Commit-Position: refs/heads/master@{#389751}

Powered by Google App Engine
This is Rietveld 408576698