Make Response::body return v8-extra based stream behind flag

Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832
Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}

Committed: https://crrev.com/053e4d396a034a48fb6d00525b249e9fdd6ac70e
Cr-Commit-Position: refs/heads/master@{#390031}

[yhirano, 2016-04-20 06:06:01]

Description was changed from

==========
Make Response::body return v8-extra based stream when enabled

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

BUG=596832
==========

to

==========
Make Response::body return v8-extra based stream when enabled

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecated Response.v8ExtraStreamBody().

BUG=596832
==========

[yhirano, 2016-04-20 06:39:39]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-04-20 07:31:41]

Description was changed from

==========
Make Response::body return v8-extra based stream when enabled

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecated Response.v8ExtraStreamBody().

BUG=596832
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecated Response.v8ExtraStreamBody().

BUG=596832
==========

[yhirano, 2016-04-20 07:32:02]

Patchset #1 (id:20001) has been deleted

[yhirano, 2016-04-20 07:32:12]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecated Response.v8ExtraStreamBody().

BUG=596832
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832
==========

[yhirano, 2016-04-20 08:32:56]

Patchset #2 (id:60001) has been deleted

[yhirano, 2016-04-20 08:33:00]

Patchset #1 (id:40001) has been deleted

[yhirano, 2016-04-20 09:05:55]

yhirano@chromium.org changed reviewers:
+ blink-reviews-bindings@chromium.org, tyoshino@chromium.org

[yhirano, 2016-04-20 09:05:56]

+blink-reviews-bindings for BodyStreamBuffer.cpp and V8HiddenValue.h

[Yuki, 2016-04-20 12:15:25]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org

[Yuki, 2016-04-20 12:15:27]

lgtm

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/Body.cpp (right):

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Body.cpp:10: #include
"bindings/core/v8/V8HiddenValue.h"
Why do you need to include V8HiddenValue.h?

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Body.cpp:19: #include
"platform/RuntimeEnabledFeatures.h"
Why do you need to include RuntimeEnabledFeatures.h?

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:91:
ASSERT(!body.IsEmpty());
This check looks a bit weird.
toV8() may return not only the empty handle but also v8::Null.  This is the
reason why the return type of toV8() is not v8::Object.  If you'd like to check
the return value, you may want the following check before converting to
v8:Object.

    v8::Local<v8::Value> body = toV8(this, scriptState);
    ASSERT(!body.IsEmpty() && body->IsObject());

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:107:
ASSERT(!body.IsEmpty());
Ditto.

[yhirano, 2016-04-21 03:41:42]

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/Body.cpp (right):

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Body.cpp:10: #include
"bindings/core/v8/V8HiddenValue.h"
On 2016/04/20 12:15:26, Yuki wrote:
> Why do you need to include V8HiddenValue.h?

Deleted.

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/Body.cpp:19: #include
"platform/RuntimeEnabledFeatures.h"
On 2016/04/20 12:15:26, Yuki wrote:
> Why do you need to include RuntimeEnabledFeatures.h?

Deleted.

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:91:
ASSERT(!body.IsEmpty());
On 2016/04/20 12:15:26, Yuki wrote:
> This check looks a bit weird.
> toV8() may return not only the empty handle but also v8::Null.  This is the
> reason why the return type of toV8() is not v8::Object.  If you'd like to
check
> the return value, you may want the following check before converting to
> v8:Object.
> 
>     v8::Local<v8::Value> body = toV8(this, scriptState);
>     ASSERT(!body.IsEmpty() && body->IsObject());

Done.

https://codereview.chromium.org/1899873006/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:107:
ASSERT(!body.IsEmpty());
On 2016/04/20 12:15:26, Yuki wrote:
> Ditto.

Done.

[Yuki, 2016-04-21 03:57:00]

lgtm

[haraken, 2016-04-21 04:36:27]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-04-21 04:36:28]

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:171:
loader->start(handle.get(), new
LoaderClient(m_scriptState->getExecutionContext(), this, client));

Don't you need:

  if (!m_scriptState->contextIsValid())
    return;

?

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:250:
ScriptState::Scope scope(m_scriptState.get());

Ditto. I guess you need to check m_scriptState->contextIsValid() before using
the ScriptState.

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h:93:
Member<ReadableByteStream> m_stream;

Just curious but is m_stream going to be removed if the V8 extra is enabled by
default?

[tyoshino (SeeGerritForStatus), 2016-04-21 07:46:24]

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:431:
m_headers->setGuard(Headers::RequestGuard);
this will be invoked again in Request(ScriptState, FetchRequestData*)?

move to the constructor at L421-?

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Response.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Response.cpp:388:
m_headers->setGuard(Headers::ResponseGuard);
ditto

[yhirano, 2016-04-21 08:14:23]

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:171:
loader->start(handle.get(), new
LoaderClient(m_scriptState->getExecutionContext(), this, client));
On 2016/04/21 04:36:28, haraken wrote:
> 
> Don't you need:
> 
>   if (!m_scriptState->contextIsValid())
>     return;
> 
> ?

I'd like to assert that the context is valid here.

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:250:
ScriptState::Scope scope(m_scriptState.get());
On 2016/04/21 04:36:28, haraken wrote:
> 
> Ditto. I guess you need to check m_scriptState->contextIsValid() before using
> the ScriptState.

I'd like to assert that the context is valid here, and that assertion is already
put in ScriptState::Scope.

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h:93:
Member<ReadableByteStream> m_stream;
On 2016/04/21 04:36:28, haraken wrote:
> 
> Just curious but is m_stream going to be removed if the V8 extra is enabled by
> default?

Yes. Actually we are planning to retire blink::Readable[Byte]Stream.

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:431:
m_headers->setGuard(Headers::RequestGuard);
On 2016/04/21 07:46:24, tyoshino wrote:
> this will be invoked again in Request(ScriptState, FetchRequestData*)?
> 
> move to the constructor at L421-?

Done.

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Response.cpp (right):

https://codereview.chromium.org/1899873006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Response.cpp:388:
m_headers->setGuard(Headers::ResponseGuard);
On 2016/04/21 07:46:24, tyoshino wrote:
> ditto

Done.

[haraken, 2016-04-21 08:26:08]

LGTM

[yhirano, 2016-04-21 08:27:53]

yhirano@chromium.org changed reviewers:
+ horo@chromium.org

[yhirano, 2016-04-21 08:27:54]

+horo@ for modules/serviceworkers, modules/cachestorage and
web/ServiceWorkerGlobalScopeProxy.cpp.

[horo, 2016-04-22 02:02:19]

On 2016/04/21 08:27:54, yhirano wrote:
> +horo@ for modules/serviceworkers, modules/cachestorage and
> web/ServiceWorkerGlobalScopeProxy.cpp.

lgtm

[tyoshino (SeeGerritForStatus), 2016-04-22 07:53:01]

lgtm

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (left):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:125: m_reader =
nullptr;
is it ok to kill this line?

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:8: #include
"bindings/core/v8/V8BindingMacros.h"
for what?

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:8: #include
"bindings/core/v8/V8BindingMacros.h"
add bindings/core/v8/V8HiddenValue.h

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:347:
controller()->enqueue(DOMUint8Array::create(static_cast<const unsigned
char*>(buffer), available));
factor out DOMUint8Array invocation to outside of the if-block?

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
(right):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h:56:
RefPtr<ScriptState> m_scriptState;
for what?

[yhirano, 2016-04-22 08:04:43]

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (left):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:125: m_reader =
nullptr;
On 2016/04/22 07:53:01, tyoshino wrote:
> is it ok to kill this line?

isStreamClosed() || isStreamErrored() means we've called close(), error() or
cancel(). In any cases m_reader should be null.

Otherwise m_reader will be cleared in close() called by this function.

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp (right):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:8: #include
"bindings/core/v8/V8BindingMacros.h"
On 2016/04/22 07:53:01, tyoshino wrote:
> for what?

It's no long used. Deleted.

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:8: #include
"bindings/core/v8/V8BindingMacros.h"
On 2016/04/22 07:53:01, tyoshino wrote:
> add bindings/core/v8/V8HiddenValue.h

Done.

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp:347:
controller()->enqueue(DOMUint8Array::create(static_cast<const unsigned
char*>(buffer), available));
On 2016/04/22 07:53:01, tyoshino wrote:
> factor out DOMUint8Array invocation to outside of the if-block?

Done.

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
(right):

https://codereview.chromium.org/1899873006/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h:56:
RefPtr<ScriptState> m_scriptState;
On 2016/04/22 07:53:01, tyoshino wrote:
> for what?

It's no long used. Deleted.

[yhirano, 2016-04-22 09:23:22]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-04-22 09:23:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org, tyoshino@chromium.org, haraken@chromium.org,
horo@chromium.org
Link to the patchset: https://codereview.chromium.org/1899873006/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-04-22 09:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899873006/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899873006/160001

[commit-bot: I haz the power, 2016-04-22 09:32:38]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832
==========

[commit-bot: I haz the power, 2016-04-22 09:32:39]

Committed patchset #5 (id:160001)

[kjellander_chromium, 2016-04-22 12:15:58]

A revert of this CL (patchset #5 id:160001) has been created in
https://codereview.chromium.org/1906403002/ by kjellander@chromium.org.

The reason for reverting is: Several tests reports leaks after this:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

.

[commit-bot: I haz the power, 2016-04-22 19:45:46]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

[commit-bot: I haz the power, 2016-04-22 19:45:47]

Patchset 5 (id:??) landed as
https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}

[yhirano, 2016-04-25 02:26:53]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

[yhirano, 2016-04-25 02:27:03]

reopen

[yhirano, 2016-04-25 03:09:51]

BodyStreamBuffer's hasPendingActivity returns true when ReadableStream is
readable and its reader is active. Hence it will be kept alive until the reader
is released. The leak is reported because the layout test's doesn't release the
reader. I fixed tests in [1]. Additionally, I make hasPendingActivity return
false when ActiveDOMObejcts are stopped in this CL (PS7).

1: https://codereview.chromium.org/1899873006/

reviewers, what do you think?

[Yuki, 2016-04-25 06:51:03]

On 2016/04/25 03:09:51, yhirano wrote:
> BodyStreamBuffer's hasPendingActivity returns true when ReadableStream is
> readable and its reader is active. Hence it will be kept alive until the
reader
> is released. The leak is reported because the layout test's doesn't release
the
> reader. I fixed tests in [1]. Additionally, I make hasPendingActivity return
> false when ActiveDOMObejcts are stopped in this CL (PS7).
> 
> 1: https://codereview.chromium.org/1899873006/
> 
> reviewers, what do you think?

Do you mean that you fixed tests in this CL?  Or mis-copy&pasting?
I don't see any fix in this CL.

[yhirano, 2016-04-25 06:53:07]

On 2016/04/25 06:51:03, Yuki wrote:
> On 2016/04/25 03:09:51, yhirano wrote:
> > BodyStreamBuffer's hasPendingActivity returns true when ReadableStream is
> > readable and its reader is active. Hence it will be kept alive until the
> reader
> > is released. The leak is reported because the layout test's doesn't release
> the
> > reader. I fixed tests in [1]. Additionally, I make hasPendingActivity return
> > false when ActiveDOMObejcts are stopped in this CL (PS7).
> > 
> > 1: https://codereview.chromium.org/1899873006/
> > 
> > reviewers, what do you think?
> 
> Do you mean that you fixed tests in this CL?  Or mis-copy&pasting?
> I don't see any fix in this CL.

Oops. Sorry, I meant https://codereview.chromium.org/1920703002/.

[Yuki, 2016-04-25 07:02:07]

I'm okay.  Differ to the experts.  LGTM.

[haraken, 2016-04-25 08:19:27]

> Additionally, I make hasPendingActivity return false when ActiveDOMObejcts are
stopped in this CL

How is this implemented?

Don't you need to clear m_loader in stop()?

[yhirano, 2016-04-25 08:24:38]

On 2016/04/25 08:19:27, haraken wrote:
> > Additionally, I make hasPendingActivity return false when ActiveDOMObejcts
are
> stopped in this CL
> 
> How is this implemented?
> 
By calling UnderlyingSourceBase::stop in BodyStreamBuffer::stop.

> Don't you need to clear m_loader in stop()?
It's technically not necessary because LoaderClient is also an ActiveDOMObject
and it clears m_loader in BodyStreamBuffer when stop is called.

[haraken, 2016-04-25 08:27:03]

On 2016/04/25 08:24:38, yhirano wrote:
> On 2016/04/25 08:19:27, haraken wrote:
> > > Additionally, I make hasPendingActivity return false when ActiveDOMObejcts
> are
> > stopped in this CL
> > 
> > How is this implemented?
> > 
> By calling UnderlyingSourceBase::stop in BodyStreamBuffer::stop.
> 
> > Don't you need to clear m_loader in stop()?
> It's technically not necessary because LoaderClient is also an ActiveDOMObject
> and it clears m_loader in BodyStreamBuffer when stop is called.

LGTM

[tyoshino (SeeGerritForStatus), 2016-04-27 07:05:54]

lgtm

[yhirano, 2016-04-27 07:59:24]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-04-27 07:59:25]

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org
Link to the patchset: https://codereview.chromium.org/1899873006/#ps220001
(title: " ")

[commit-bot: I haz the power, 2016-04-27 07:59:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899873006/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899873006/220001

[commit-bot: I haz the power, 2016-04-27 08:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 08:02:11]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[yhirano, 2016-04-27 08:27:47]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-04-27 08:27:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org, haraken@chromium.org, yukishiino@chromium.org,
horo@chromium.org
Link to the patchset: https://codereview.chromium.org/1899873006/#ps240001
(title: " ")

[commit-bot: I haz the power, 2016-04-27 08:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899873006/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899873006/240001

[commit-bot: I haz the power, 2016-04-27 09:32:56]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

[commit-bot: I haz the power, 2016-04-27 09:32:58]

Committed patchset #9 (id:240001)

[commit-bot: I haz the power, 2016-04-27 09:34:28]

Description was changed from

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}
==========

to

==========
Make Response::body return v8-extra based stream behind flag

This CL makes Response::body return a v8-extra based ReadableStream when
ResponseBodyWithV8ExtraStream is enabled.

This CL also deprecates Response.v8ExtraStreamBody().

BUG=596832

Committed: https://crrev.com/4d1201da5903586ded0a446d670aa502af359c1a
Cr-Commit-Position: refs/heads/master@{#389063}

Committed: https://crrev.com/053e4d396a034a48fb6d00525b249e9fdd6ac70e
Cr-Commit-Position: refs/heads/master@{#390031}
==========

[commit-bot: I haz the power, 2016-04-27 09:34:30]

Patchset 9 (id:??) landed as
https://crrev.com/053e4d396a034a48fb6d00525b249e9fdd6ac70e
Cr-Commit-Position: refs/heads/master@{#390031}