Issue 192065: Merge 25487 - Strip .plugin off of Mac plugin names when showing the crash in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 192065: Merge 25487 - Strip .plugin off of Mac plugin names when showing the crash in... (Closed)

Created:
11 years, 3 months ago by Mark Larson

Modified:
9 years, 7 months ago

Reviewers:
laforge, Miranda Callahan

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 25487 - Strip .plugin off of Mac plugin names when showing the crash info bar. ** This fixes the build break. Merging r25834 introduced a dependency on EndsWith. ** This change only adds code, and we know that the only caller is the code in r25834. BUG=21029 TEST=Kill a plugin process; the plugin crash info bar shouldn't have ".plugin" in the plugin name. Review URL: http://codereview.chromium.org/197018 TBR=mirandac@chromium.org, laforge@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25854

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -1 line)			Patch
MM	base/string_util.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
MM	base/string_util.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
MM	base/string_util_unittest.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
MM	chrome/browser/tab_contents/tab_contents.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Larson

Setting Miranda and Anthony as reviewers so they see this. Already checked in, but please ...

11 years, 3 months ago (2009-09-10 07:50:47 UTC) #2

Miranda Callahan

11 years, 3 months ago (2009-09-10 16:48:52 UTC) #3

Oh, interesting -- I didn't know EndsWith was so new.  Thanks -- lg, of course.

On 2009/09/10 07:50:47, Mark Larson wrote:
> Setting Miranda and Anthony as reviewers so they see this. 
> 
> Already checked in, but please have a look.

Expand Messages | Collapse Messages