Strip .plugin off of Mac plugin names when showing the crash info bar.

Strip .plugin off of Mac plugin names when showing the crash info bar.

BUG=21029
TEST=Kill a plugin process; the plugin crash info bar shouldn't have ".plugin" in the plugin name.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25487

[Mark Mentovai, 2009-09-03 23:40:53]

LG but...

http://codereview.chromium.org/197018/diff/1/2
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/197018/diff/1/2#newcode1665
Line 1665: std::wstring::size_type suffix_start = plugin_name.rfind(L".plugin");
I don't like that this will find ".plugin" in the string at locations in
addition to the end.  Could you do a more proper "ends with" check?

[stuartmorgan, 2009-09-04 00:29:54]

New version up testing the suffix explicitly.

[Mark Mentovai, 2009-09-04 05:47:59]

LG

http://codereview.chromium.org/197018/diff/6/7
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/197018/diff/6/7#newcode1671
Line 1671: plugin_name.erase(suffix_test_start);
Put this inside an {} for readability, because the controlling condition takes
up more than one line.

The style guide doesn't absolutely require this although it does suggest it. 
It's good for readability here anyway.

http://codereview.chromium.org/197018/diff/6/7#newcode1672
Line 1672: #endif
// OS_MACOSX here now.  The #ifdef is probably guarding enough stuff that it's
worthwhile.

[Mark Mentovai, 2009-09-04 05:52:13]

http://codereview.chromium.org/197018/diff/6/7
File chrome/browser/tab_contents/tab_contents.cc (right):

http://codereview.chromium.org/197018/diff/6/7#newcode1668
Line 1668: if (suffix_test_start > 0 &&
Oops.  std::wstring::size_type is unsigned.  |> 0| doesn't do what you want, and
then...

http://codereview.chromium.org/197018/diff/6/7#newcode1669
Line 1669: plugin_name.compare(suffix_test_start, plugin_extension.length(),
...ouch, out of range.

[stuartmorgan, 2009-09-04 18:03:12]

Trying again, this time with a utility function and a unit test.

[Mark Mentovai, 2009-09-04 18:09:00]

Looks good

http://codereview.chromium.org/197018/diff/3002/10
File base/string_util_unittest.cc (right):

http://codereview.chromium.org/197018/diff/3002/10#newcode1592
Line 1592: }
I'd also add a few cases to test |str == search|, including when both are L"".