Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1920453004: Make non-recipe builders that use MB work w/ goma properly. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make non-recipe builders that use MB work w/ goma properly. TBR=nodir@chromium.org BUG=606082 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300129

Patch Set 1 : patch for review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M scripts/master/factory/commands.py View 2 chunks +8 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
4 years, 8 months ago (2016-04-23 00:40:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920453004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920453004/20001
4 years, 8 months ago (2016-04-23 00:40:58 UTC) #4
nodir
rs lgtm, have close-to-0 understanding of this https://codereview.chromium.org/1920453004/diff/20001/scripts/master/factory/commands.py File scripts/master/factory/commands.py (right): https://codereview.chromium.org/1920453004/diff/20001/scripts/master/factory/commands.py#newcode1074 scripts/master/factory/commands.py:1074: cmd += ...
4 years, 8 months ago (2016-04-23 00:43:38 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:44:56 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300129

Powered by Google App Engine
This is Rietveld 408576698