Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: scripts/master/factory/commands.py

Issue 1920453004: Make non-recipe builders that use MB work w/ goma properly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: patch for review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/commands.py
diff --git a/scripts/master/factory/commands.py b/scripts/master/factory/commands.py
index 2cf33a078fb62273b819cd9b0c907aaf2d552be6..676c3024e977b4793be1669f18f4a8c3d621abfd 100644
--- a/scripts/master/factory/commands.py
+++ b/scripts/master/factory/commands.py
@@ -1048,9 +1048,6 @@ class FactoryCommands(object):
cmd = [self._python, self._runhooks_tool]
options = options or {}
- if '--compiler=goma' in options or '--compiler=goma-clang' in options:
- cmd.append('--use-goma')
-
self._factory.addStep(
shell.ShellCommand,
haltOnFailure=True,
@@ -1063,14 +1060,20 @@ class FactoryCommands(object):
def AddGenerateBuildFilesStep(self, env=None, timeout=None, options=None,
config_file_path=None, target=None):
+ options = options or []
if not config_file_path:
config_file_path = self.PathJoin(self._repository_root,
'tools', 'mb', 'mb_config.pyl')
+
cmd = [self._python, self._mb_tool, 'gen',
'-m', WithProperties('%(mastername)s'),
'-b', WithProperties('%(buildername)s'),
- '--config-file', config_file_path,
- '//out/%s' % target]
+ '--config-file', config_file_path]
+
+ if '--compiler=goma' in options or '--compiler=goma-clang' in options:
+ cmd += ['--goma-dir', self.PathJoin('..', '..', '..', '..', 'goma')]
nodir 2016/04/23 00:43:38 ugh
+
+ cmd += ['//out/%s' % target]
self._factory.addStep(
shell.ShellCommand,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698