Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: content/test/gpu/PRESUBMIT.py

Issue 1920403002: [content/test/gpu] Run pylint check of gpu tests in unittest instead of PRESUBMIT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/lint_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/PRESUBMIT.py
diff --git a/content/test/gpu/PRESUBMIT.py b/content/test/gpu/PRESUBMIT.py
index da0d24fe639a5aa9c5805fbccee6b2c38d36f2b0..2764d1a8cf81f9fcde439744c5355fe2b70ab826 100644
--- a/content/test/gpu/PRESUBMIT.py
+++ b/content/test/gpu/PRESUBMIT.py
@@ -10,11 +10,6 @@ for more details about the presubmit API built into depot_tools.
import re
-def _PyLintChecks(input_api, output_api):
- pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api,
- extra_paths_list=_GetPathsToPrepend(input_api), pylintrc='pylintrc')
- return input_api.RunTests(pylint_checks)
-
def _GetPathsToPrepend(input_api):
current_dir = input_api.PresubmitLocalPath()
chromium_src_dir = input_api.os_path.join(current_dir, '..', '..', '..')
@@ -57,13 +52,11 @@ def _WebGLTextExpectationsTests(input_api, output_api):
def CheckChangeOnUpload(input_api, output_api):
results = []
- results.extend(_PyLintChecks(input_api, output_api))
Ken Russell (switch to Gerrit) 2016/04/27 09:54:45 Can we run all of the GPU unit tests upon upload?
nednguyen 2016/04/27 17:30:02 We already did at line 61 & 67. I remember you was
Ken Russell (switch to Gerrit) 2016/04/27 17:33:28 It wasn't obvious to me any more that "_WebGLTextE
nednguyen 2016/04/27 17:42:31 Done in https://codereview.chromium.org/1923183003
results.extend(_WebGLTextExpectationsTests(input_api, output_api))
return results
def CheckChangeOnCommit(input_api, output_api):
results = []
- results.extend(_PyLintChecks(input_api, output_api))
results.extend(_WebGLTextExpectationsTests(input_api, output_api))
return results
« no previous file with comments | « no previous file | content/test/gpu/gpu_tests/lint_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698