[content/test/gpu] Run pylint check of gpu tests in unittest instead of PRESUBMIT

content/test/gpu/PRESUBMIT.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for content/test/gpu.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into depot_tools.
 """
 
 import re
 
-def _PyLintChecks(input_api, output_api):
-  pylint_checks = input_api.canned_checks.GetPylint(input_api, output_api,
-          extra_paths_list=_GetPathsToPrepend(input_api), pylintrc='pylintrc')
-  return input_api.RunTests(pylint_checks)
-
 def _GetPathsToPrepend(input_api):
   current_dir = input_api.PresubmitLocalPath()
   chromium_src_dir = input_api.os_path.join(current_dir, '..', '..', '..')
   return [
     input_api.os_path.join(current_dir, 'gpu_tests'),
     input_api.os_path.join(chromium_src_dir, 'tools', 'perf'),
     input_api.os_path.join(chromium_src_dir,
         'third_party', 'catapult', 'telemetry'),
     input_api.os_path.join(chromium_src_dir,
         'third_party', 'catapult', 'catapult_base'),
@@ skipping 22 matching lines @@
     kwargs={},
     message=message_type,
   )
 
   if input_api.verbose:
     print 'Running', cmd_name
   return input_api.RunTests([test_cmd])
 
 def CheckChangeOnUpload(input_api, output_api):
   results = []
-  results.extend(_PyLintChecks(input_api, output_api))

[Ken Russell (switch to Gerrit), 2016/04/27 09:54:45]

Can we run all of the GPU unit tests upon upload? It's important that the lint
checks be done at this point rather than the CQ failing the CL.

[nednguyen, 2016/04/27 17:30:02]

We already did at line 61 & 67. I remember you was the one who set it this way
:-)

[Ken Russell (switch to Gerrit), 2016/04/27 17:33:28]

It wasn't obvious to me any more that "_WebGLTextExpectationsTests" ran all of
the unittests. Could you rename that function to make it more obvious what it
does? Thanks.

[nednguyen, 2016/04/27 17:42:31]

Done in https://codereview.chromium.org/1923183003

   results.extend(_WebGLTextExpectationsTests(input_api, output_api))
   return results
 
 def CheckChangeOnCommit(input_api, output_api):
   results = []
-  results.extend(_PyLintChecks(input_api, output_api))
   results.extend(_WebGLTextExpectationsTests(input_api, output_api))
   return results
 
 def PostUploadHook(cl, change, output_api):
   """git cl upload will call this hook after the issue is created/modified.
 
   This hook adds extra try bots list to the CL description in order to run
   Blink tests in addition to CQ try bots.
   """
   rietveld_obj = cl.RpcServer()
@@ skipping 11 matching lines @@
   results = []
   new_description = description
   new_description += '\nCQ_INCLUDE_TRYBOTS=%s' % ';'.join(bots)
   results.append(output_api.PresubmitNotifyResult(
       'Automatically added optional GPU tests to run on CQ.'))
 
   if new_description != description:
     rietveld_obj.update_description(issue, new_description)
 
   return results