Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1920353002: Implement create attribute API functions for BTLE. (Closed)

Created:
4 years, 8 months ago by rkc
Modified:
4 years, 7 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@api_changes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement create attribute API functions for BTLE. This CL implements the createService, createCharacteristic and createDescriptor functions for the bluetoothLowEnergy API and adds basic tests for it. Currently this CL does not set up a delegate for receiving events from the remote central device, which is fine though since the register function has not been implemented yet. Note: We're implementing Chrome OS specific tests to be able to test the complete stack. Using the platform independent tests did not work very well since we'd not be able to successfully call any of the ::Create(...) calls. Since this API will only ever be available on Chrome OS and Linux, this should be fine. R=ortuno@chromium.org, scheib@chromium.org BUG=606217 Committed: https://crrev.com/5916b89a5e4e0a055bdc773d1cb8552a96828144 Cr-Commit-Position: refs/heads/master@{#391456}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : merge #

Patch Set 9 : owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -32 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/OWNERS View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.h View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 1 2 3 4 5 6 7 8 chunks +73 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest_chromeos.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc View 2 chunks +28 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth_low_energy/create_characteristic/manifest.json View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth_low_energy/create_characteristic/runtest.js View 1 chunk +43 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth_low_energy/create_descriptor/manifest.json View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth_low_energy/create_descriptor/runtest.js View 1 chunk +50 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service/manifest.json View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth_low_energy/create_service/runtest.js View 1 chunk +18 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 2 chunks +6 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth_local_gatt_service.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 2 chunks +4 lines, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.h View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_local_gatt_service_bluez.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -2 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc View 1 2 3 4 5 6 7 8 1 chunk +7 lines, -6 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 37 (16 generated)
rkc
4 years, 8 months ago (2016-04-26 22:02:23 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/60001
4 years, 7 months ago (2016-04-28 03:11:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/26428) ios_dbg_simulator_ninja on ...
4 years, 7 months ago (2016-04-28 03:14:44 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/80001
4 years, 7 months ago (2016-04-29 05:01:04 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/130035)
4 years, 7 months ago (2016-04-29 05:15:17 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/100001
4 years, 7 months ago (2016-04-29 09:24:46 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/103735)
4 years, 7 months ago (2016-04-29 09:33:01 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/120001
4 years, 7 months ago (2016-04-30 20:32:34 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/15039)
4 years, 7 months ago (2016-04-30 21:08:47 UTC) #17
scheib
LGTM https://codereview.chromium.org/1920353002/diff/120001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc (right): https://codereview.chromium.org/1920353002/diff/120001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc#newcode1065 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc:1065: VLOG(1) << "Local characteristic with id " << ...
4 years, 7 months ago (2016-05-04 00:48:53 UTC) #18
rkc
merge
4 years, 7 months ago (2016-05-04 00:53:42 UTC) #19
rkc
https://codereview.chromium.org/1920353002/diff/120001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc File chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc (right): https://codereview.chromium.org/1920353002/diff/120001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc#newcode1065 chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc:1065: VLOG(1) << "Local characteristic with id " << id ...
4 years, 7 months ago (2016-05-04 01:56:28 UTC) #20
scheib
On 2016/05/04 01:56:28, Rahul Chaturvedi wrote: > https://codereview.chromium.org/1920353002/diff/120001/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc > File > chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_event_router.cc > (right): > ...
4 years, 7 months ago (2016-05-04 02:31:56 UTC) #21
scheib
LGTM
4 years, 7 months ago (2016-05-04 02:32:12 UTC) #22
commit-bot: I haz the power
This CL has an open dependency (Issue 1915243003 Patch 460001). Please resolve the dependency and ...
4 years, 7 months ago (2016-05-04 03:50:47 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/140001
4 years, 7 months ago (2016-05-04 05:16:54 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/177302)
4 years, 7 months ago (2016-05-04 05:24:41 UTC) #29
Ken Rockot(use gerrit already)
lgtm - please update the BLE OWNERs to reflect current bluetooth owners
4 years, 7 months ago (2016-05-04 05:29:22 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920353002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920353002/160001
4 years, 7 months ago (2016-05-04 05:33:33 UTC) #34
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 7 months ago (2016-05-04 07:42:23 UTC) #35
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 07:43:46 UTC) #37
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/5916b89a5e4e0a055bdc773d1cb8552a96828144
Cr-Commit-Position: refs/heads/master@{#391456}

Powered by Google App Engine
This is Rietveld 408576698