Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1920293004: Hide pseudo sinks when user has no hosted domain. (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible, amp
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide pseudo sinks when user has no hosted domain. This change prevents users without a hosted domain (e.g. @gmail.com users) from seeing the "Add a hangout" pseudo sink in the MR dialog filter view. Trying to create a named hangout for them will always fail. BUG=607333 R=amp@chromium.org, apacible@chromium.org Committed: https://crrev.com/b8906da25102968ee173acbb234728902ae4bb03 Cr-Commit-Position: refs/heads/master@{#390266}

Patch Set 1 #

Patch Set 2 : Pseudo sink empty domain test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/test/data/webui/media_router/media_router_container_search_tests.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
btolsch
PTAL, thanks!
4 years, 7 months ago (2016-04-27 23:14:18 UTC) #1
amp
LGTM https://codereview.chromium.org/1920293004/diff/20001/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc File chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc (right): https://codereview.chromium.org/1920293004/diff/20001/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc#newcode109 chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc:109: if (domain == Profile::kNoHostedDomainFound) { Thanks for updating ...
4 years, 7 months ago (2016-04-27 23:26:19 UTC) #2
apacible
lgtm
4 years, 7 months ago (2016-04-27 23:30:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1920293004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1920293004/20001
4 years, 7 months ago (2016-04-28 00:02:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 01:14:54 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:15:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b8906da25102968ee173acbb234728902ae4bb03
Cr-Commit-Position: refs/heads/master@{#390266}

Powered by Google App Engine
This is Rietveld 408576698