chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc - Issue 1920293004: Hide pseudo sinks when user has no hosted domain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

Issue 1920293004: Hide pseudo sinks when user has no hosted domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pseudo sink empty domain test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js ('k') | chrome/test/data/webui/media_router/media_router_container_search_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

index 3ae44f63437e3266219df61791f2d64ca3c501a5..00eecdf4991d5cdc88ee802ff6b2d48528fd1b1d 100644

--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc

@@ -106,7 +106,7 @@ std::unique_ptr<base::DictionaryValue> SinksAndIdentityToValue(

// Convert default domains to user domain

if (sink.domain() == "default") {

domain = user_domain;

- if (domain == "NO_HOSTED_DOMAIN") {

+ if (domain == Profile::kNoHostedDomainFound) {

amp 2016/04/27 23:26:19 Thanks for updating this reference. :)

// Default domain will be empty for non-dasher accounts.

domain.clear();

}