Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1920293003: Fix line wrappiing when break-word/break-all and float with 100% width (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Fix line wrappiing when break-word/break-all and float with 100% width This patch changes the line breaker to rewindToMidWordBreak() after it computes fitBelowFloats(). rewindToMidWordBreak() uses LineWidth::availableWidth(), which fitBelowFloats() may change if floats fill the whole line and the start of the line is pushed down below the floats. BUG=603679 Review URL: https://codereview.chromium.org/1900393002 Cr-Commit-Position: refs/heads/master@{#388996} (cherry picked from commit a4e4eb3b4334905bc874dea2264b450f029fb605) Committed: https://chromium.googlesource.com/chromium/src/+/e583672da5cd5b223702b74e65c823a66c629f6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-wrap-with-100percent-floats.html View 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
4 years, 8 months ago (2016-04-27 01:08:36 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e583672da5cd5b223702b74e65c823a66c629f6c.

Powered by Google App Engine
This is Rietveld 408576698