Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 1900393002: Fix line wrappiing when break-word/break-all and float with 100% width (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix line wrappiing when break-word/break-all and float with 100% width This patch changes the line breaker to rewindToMidWordBreak() after it computes fitBelowFloats(). rewindToMidWordBreak() uses LineWidth::availableWidth(), which fitBelowFloats() may change if floats fill the whole line and the start of the line is pushed down below the floats. BUG=603679 Committed: https://crrev.com/a4e4eb3b4334905bc874dea2264b450f029fb605 Cr-Commit-Position: refs/heads/master@{#388996}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Add test #

Patch Set 4 : Add log div to the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/fast/css3-text/css3-word-break/word-break-all-wrap-with-100percent-floats.html View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 2 3 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kojii
PTAL. Another minor regression for the break-all fix.
4 years, 8 months ago (2016-04-21 13:16:14 UTC) #5
eae
LGTM
4 years, 8 months ago (2016-04-21 16:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900393002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900393002/60001
4 years, 8 months ago (2016-04-22 00:41:07 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-22 01:23:35 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:43:16 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a4e4eb3b4334905bc874dea2264b450f029fb605
Cr-Commit-Position: refs/heads/master@{#388996}

Powered by Google App Engine
This is Rietveld 408576698