Revert of Reland: [qcms] Fix build_output_lut to return correct data for parametric curves

Revert of Reland: [qcms] Fix build_output_lut to return correct data for parametric curves (patchset #14 id:260001 of https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
>
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
>
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
>
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
>
> BUG=600338
>
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
>
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338
Committed: https://crrev.com/517ca6467545ddd4e0281f3302d65871f4164603
Cr-Commit-Position: refs/heads/master@{#389877}

[Charlie Reis, 2016-04-26 20:54:59]

Created Revert of Reland: [qcms] Fix build_output_lut to return correct data for
parametric curves

[commit-bot: I haz the power, 2016-04-26 20:55:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1920253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1920253003/1

[commit-bot: I haz the power, 2016-04-26 20:56:09]

Description was changed from

==========
Revert of Reland: [qcms] Fix build_output_lut to return correct data for
parametric curves (patchset #14 id:260001 of
https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
> 
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
> 
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
> 
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
> 
> BUG=600338
> 
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
> 
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338
==========

to

==========
Revert of Reland: [qcms] Fix build_output_lut to return correct data for
parametric curves (patchset #14 id:260001 of
https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
> 
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
> 
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
> 
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
> 
> BUG=600338
> 
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
> 
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338
==========

[commit-bot: I haz the power, 2016-04-26 20:56:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-26 20:57:42]

Description was changed from

==========
Revert of Reland: [qcms] Fix build_output_lut to return correct data for
parametric curves (patchset #14 id:260001 of
https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
> 
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
> 
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
> 
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
> 
> BUG=600338
> 
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
> 
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338
==========

to

==========
Revert of Reland: [qcms] Fix build_output_lut to return correct data for
parametric curves (patchset #14 id:260001 of
https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
>
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
>
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
>
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
>
> BUG=600338
>
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
>
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338

Committed: https://crrev.com/517ca6467545ddd4e0281f3302d65871f4164603
Cr-Commit-Position: refs/heads/master@{#389877}
==========

[commit-bot: I haz the power, 2016-04-26 20:57:43]

Patchset 1 (id:??) landed as
https://crrev.com/517ca6467545ddd4e0281f3302d65871f4164603
Cr-Commit-Position: refs/heads/master@{#389877}

[Noel Gordon, 2016-04-26 22:49:27]

LGTM, not sure why the try jobs (which were all green) do no pick up the compile
failure on CQ, odd.

[radu.velea, 2016-04-26 23:09:58]

On 2016/04/26 22:49:27, noel gordon wrote:
> LGTM, not sure why the try jobs (which were all green) do no pick up the
compile
> failure on CQ, odd.

I'll fix the warning and try again. Unfortunately I don't have a win machine to
test locally. ninja and make -wall don't show any warnings.
sorry for the mess.

[Noel Gordon, 2016-04-26 23:56:06]

On 2016/04/26 23:09:58, radu.velea wrote:

> I'll fix the warning and try again. Unfortunately I don't have a win machine
to
> test locally.

I have a win machine, I will try a local build.

> ninja and make -wall don't show any warnings, sorry for the mess.

I see no warning with -Wall either.