Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 192017: Convert std::wstring encoding names to std::string in a bunch of files. (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert std::wstring encoding names to std::string in a bunch of files. BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com>; at http://codereview.chromium.org/179057/show Some linux related fixes by me.

Patch Set 1 #

Patch Set 2 : mac and linux fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -254 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/browser_encoding_uitest.cc View 5 chunks +54 lines, -54 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/character_encoding.h View 5 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/character_encoding.cc View 15 chunks +77 lines, -76 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/encoding_menu_controller.h View 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/encoding_menu_controller.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/encoding_menu_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_toolbar_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/gtk/options/fonts_page_gtk.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/parsers/metadata_parser_filebase.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.h View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
chrome/renderer/render_view.h View 1 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
chrome/test/automated_ui_tests/automated_ui_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/automation/tab_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 chunk +1 line, -1 line 0 comments Download
webkit/glue/webview.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
webkit/glue/webview_impl.h View 1 4 chunks +10 lines, -6 lines 0 comments Download
M webkit/glue/webview_impl.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698