Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: chrome/browser/cocoa/encoding_menu_controller_delegate_mac.mm

Issue 192017: Convert std::wstring encoding names to std::string in a bunch of files. (Closed)
Patch Set: mac and linux fixes Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h" 5 #include "chrome/browser/cocoa/encoding_menu_controller_delegate_mac.h"
6 6
7 #import <Cocoa/Cocoa.h> 7 #import <Cocoa/Cocoa.h>
8 8
9 #include "base/string16.h"
9 #include "base/sys_string_conversions.h" 10 #include "base/sys_string_conversions.h"
10 #include "chrome/app/chrome_dll_resource.h" 11 #include "chrome/app/chrome_dll_resource.h"
11 #include "chrome/browser/browser.h" 12 #include "chrome/browser/browser.h"
12 #include "chrome/browser/encoding_menu_controller.h" 13 #include "chrome/browser/encoding_menu_controller.h"
13 #include "chrome/browser/profile.h" 14 #include "chrome/browser/profile.h"
14 15
15 namespace { 16 namespace {
16 17
17 void AddSeparatorToMenu(NSMenu *parent_menu) { 18 void AddSeparatorToMenu(NSMenu *parent_menu) {
18 NSMenuItem* separator = [NSMenuItem separatorItem]; 19 NSMenuItem* separator = [NSMenuItem separatorItem];
(...skipping 23 matching lines...) Expand all
42 43
43 typedef EncodingMenuController::EncodingMenuItemList EncodingMenuItemList; 44 typedef EncodingMenuController::EncodingMenuItemList EncodingMenuItemList;
44 EncodingMenuItemList menuItems; 45 EncodingMenuItemList menuItems;
45 EncodingMenuController controller; 46 EncodingMenuController controller;
46 controller.GetEncodingMenuItems(profile, &menuItems); 47 controller.GetEncodingMenuItems(profile, &menuItems);
47 48
48 for (EncodingMenuItemList::iterator it = menuItems.begin(); 49 for (EncodingMenuItemList::iterator it = menuItems.begin();
49 it != menuItems.end(); 50 it != menuItems.end();
50 ++it) { 51 ++it) {
51 int item_id = it->first; 52 int item_id = it->first;
52 std::wstring &localized_title_wstring = it->second; 53 string16 &localized_title_string16 = it->second;
53 54
54 if (item_id == 0) { 55 if (item_id == 0) {
55 AddSeparatorToMenu(encoding_menu); 56 AddSeparatorToMenu(encoding_menu);
56 } else { 57 } else {
57 using base::SysWideToNSString; 58 using base::SysWideToNSString;
58 NSString *localized_title = SysWideToNSString(localized_title_wstring); 59 NSString *localized_title = SysUTF16ToNSString(localized_title_string16);
59 AppendMenuItem(encoding_menu, item_id, localized_title); 60 AppendMenuItem(encoding_menu, item_id, localized_title);
60 } 61 }
61 } 62 }
62 63
63 } 64 }
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/browser_window_controller.mm ('k') | chrome/browser/encoding_menu_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698