Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1919843002: Revert of Batch multiple single NVPR draw paths to instanced draws (Closed)

Created:
4 years, 8 months ago by stephana
Modified:
4 years, 8 months ago
CC:
reviews_skia.org, Chris Dalton, Sami Väisänen
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Batch multiple single NVPR draw paths to instanced draws (patchset #5 id:80001 of https://codereview.chromium.org/1908433002/ ) Reason for revert: This causes what looks like significantly wrong results. Here is an example: https://gold.skia.org/diff?test=stroke-fill&left=cb47dc2cabbad7d146aedaac199ebace&top=2c6e65d597c574e3bb170a19ca9634c6 Original issue's description: > Batch multiple single NVPR draw paths to instanced draws > > Batch multiple single NVPR draw paths to instanced draws. > A draw path batch can be combined to other batch if the > batches do not overlap and have same draw characteristics. > > Join the batches in linked list and flatten the list to a > path list during draw time. > > Replace GrPathRendering::drawPath with GrPathRendering::drawPaths. > > Perf changes ARM, Shield TV device, Tegra X1 GPU: > desk_chalkboard.skp_1 21.5ms -> 17.8ms 0.83x > desk_mapsvg.skp_1 7.49ms -> 6.18ms 0.82x > Others results are more volatile. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908433002 > > Committed: https://skia.googlesource.com/skia/+/3c33c389e9f8d14d86756ea1ddeba2097f31ad22 TBR=joshualitt@chromium.org,bsalomon@google.com,kkinnunen@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/1dc172165b8186950fda4a269bd1b12c11947b14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -182 lines) Patch
M src/gpu/GrPath.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/GrPathRendering.h View 3 chunks +15 lines, -17 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 chunk +5 lines, -12 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +5 lines, -71 lines 0 comments Download
M src/gpu/gl/GrGLPath.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 2 chunks +29 lines, -56 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
stephana
Created Revert of Batch multiple single NVPR draw paths to instanced draws
4 years, 8 months ago (2016-04-25 14:01:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919843002/1
4 years, 8 months ago (2016-04-25 14:01:15 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 14:01:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1dc172165b8186950fda4a269bd1b12c11947b14

Powered by Google App Engine
This is Rietveld 408576698