Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 1919813003: Apply arflags to dependent configs in GN. (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply arflags to dependent configs in GN. Previously they were not copied from child configs so they wouldn't work in all cases. This also adds arflags support for "gn desc", and changes ldflags to no longer be printed for static libraries and source sets (since it doesn't apply, this is unnecessary and confusing). Committed: https://crrev.com/10b4460a4180b1cff25517c1e4cdae3b9e5c02cb Cr-Commit-Position: refs/heads/master@{#389565}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M tools/gn/command_desc.cc View 3 chunks +8 lines, -1 line 0 comments Download
M tools/gn/config_values.h View 2 chunks +6 lines, -1 line 0 comments Download
M tools/gn/config_values.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
brettw
I don't have a brilliant idea about how to verify that you don't forget to ...
4 years, 8 months ago (2016-04-25 18:36:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919813003/20001
4 years, 8 months ago (2016-04-25 18:36:21 UTC) #5
brucedawson
lgtm
4 years, 8 months ago (2016-04-25 19:52:52 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-25 20:15:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919813003/20001
4 years, 8 months ago (2016-04-25 21:24:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 21:30:51 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 21:32:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10b4460a4180b1cff25517c1e4cdae3b9e5c02cb
Cr-Commit-Position: refs/heads/master@{#389565}

Powered by Google App Engine
This is Rietveld 408576698