Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1919793002: Revert of Add enablePerThreadHeap flag to ThreadState (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add enablePerThreadHeap flag to ThreadState (patchset #3 id:40001 of https://codereview.chromium.org/1910753002/ ) Reason for revert: Reverting in order to revert r 389052 Original issue's description: > Add enablePerThreadHeap flag to ThreadState > > BUG=591606 > > Committed: https://crrev.com/e5b8b2832fccc2cbe039698235669b029778f58d > Cr-Commit-Position: refs/heads/master@{#389436} TBR=oilpan-reviews@chromium.org,haraken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=591606 Committed: https://crrev.com/537b169259bf719f6c31fd2085b69f0180bb4dc2 Cr-Commit-Position: refs/heads/master@{#389451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -38 lines) Patch
M third_party/WebKit/Source/platform/WebThreadSupportingGC.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 4 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
keishi
Created Revert of Add enablePerThreadHeap flag to ThreadState
4 years, 8 months ago (2016-04-25 12:10:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919793002/1
4 years, 8 months ago (2016-04-25 12:10:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 12:11:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/537b169259bf719f6c31fd2085b69f0180bb4dc2 Cr-Commit-Position: refs/heads/master@{#389451}
4 years, 8 months ago (2016-04-25 12:12:45 UTC) #5
haraken
4 years, 8 months ago (2016-04-25 12:22:25 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698