Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1919793002: Revert of Add enablePerThreadHeap flag to ThreadState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp
diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
index 155e31138bbbffc8f2b7d7164fd1bde8e007987f..d8882ad5babb73e58f7d680967f1331d4e2c1940 100644
--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp
+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp
@@ -73,7 +73,7 @@
uintptr_t ThreadState::s_mainThreadUnderestimatedStackSize = 0;
uint8_t ThreadState::s_mainThreadStateStorage[sizeof(ThreadState)];
-ThreadState::ThreadState(bool perThreadHeapEnabled)
+ThreadState::ThreadState()
: m_thread(currentThread())
, m_persistentRegion(adoptPtr(new PersistentRegion()))
#if OS(WIN) && COMPILER(MSVC)
@@ -90,7 +90,6 @@
, m_accumulatedSweepingTime(0)
, m_vectorBackingArenaIndex(BlinkGC::Vector1ArenaIndex)
, m_currentArenaAges(0)
- , m_perThreadHeapEnabled(perThreadHeapEnabled)
, m_isTerminating(false)
, m_gcMixinMarker(nullptr)
, m_shouldFlushHeapDoesNotContainCache(false)
@@ -111,12 +110,7 @@
ASSERT(!**s_threadSpecific);
**s_threadSpecific = this;
- // TODO(keishi) Remove when per thread heap is ready.
- CHECK(!m_perThreadHeapEnabled);
-
- if (m_perThreadHeapEnabled) {
- m_heap = new ThreadHeap();
- } else if (isMainThread()) {
+ if (isMainThread()) {
s_mainThreadStackStart = reinterpret_cast<uintptr_t>(m_startOfStack) - sizeof(void*);
size_t underestimatedStackSize = StackFrameDepth::getUnderestimatedStackSize();
if (underestimatedStackSize > sizeof(void*))
@@ -195,13 +189,13 @@
{
RELEASE_ASSERT(!ProcessHeap::s_shutdownComplete);
s_threadSpecific = new WTF::ThreadSpecific<ThreadState*>();
- new (s_mainThreadStateStorage) ThreadState(false);
-}
-
-void ThreadState::attachCurrentThread(bool perThreadHeapEnabled)
+ new (s_mainThreadStateStorage) ThreadState();
+}
+
+void ThreadState::attachCurrentThread()
{
RELEASE_ASSERT(!ProcessHeap::s_shutdownComplete);
- new ThreadState(perThreadHeapEnabled);
+ new ThreadState();
}
void ThreadState::cleanupPages()
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698