Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1919753002: Allow null jstring to C++ string conversions in release. (Closed)

Created:
4 years, 8 months ago by Torne
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Allow null jstring to C++ string conversions in release. WebView has too many cases where apps can pass in a null java string and have it reach native causing a crash. For now, put back the code that returned empty string, but keep the DCHECK so that we still hit it on bots that run with DCHECKs enabled. We'll fix WebView and have another go at this in a later release. This is a partial revert of https://codereview.chromium.org/1828193002 BUG=597564 Review URL: https://codereview.chromium.org/1913183002 Cr-Commit-Position: refs/heads/master@{#389166} (cherry picked from commit 075418c032dd093e52aef9e56b8a3eb55eb7dc58) Committed: https://chromium.googlesource.com/chromium/src/+/35f63706d80bd84b2f5ccd5e5f251243a7805731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M base/android/jni_string.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Torne
4 years, 8 months ago (2016-04-25 10:12:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
35f63706d80bd84b2f5ccd5e5f251243a7805731.

Powered by Google App Engine
This is Rietveld 408576698