Allow null jstring to C++ string conversions in release.

Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564
Committed: https://crrev.com/075418c032dd093e52aef9e56b8a3eb55eb7dc58
Cr-Commit-Position: refs/heads/master@{#389166}

[Torne, 2016-04-22 17:05:27]

Description was changed from

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

BUG=597564
==========

to

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564
==========

[Torne, 2016-04-22 17:05:46]

torne@chromium.org changed reviewers:
+ tobiasjs@chromium.org

[Torne, 2016-04-22 17:05:47]

Toby, can you take a quick look? (I'm a base/android OWNER already ;)

[Tobias Sargeant, 2016-04-22 17:08:15]

On 2016/04/22 17:05:47, Torne wrote:
> Toby, can you take a quick look? (I'm a base/android OWNER already ;)

LGTM.

[Torne, 2016-04-22 17:08:55]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2016-04-22 17:09:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1913183002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1913183002/1

[Torne, 2016-04-22 17:11:15]

torne@chromium.org changed reviewers:
+ bauerb@chromium.org

[Torne, 2016-04-22 17:11:15]

Adding bauerb@ as an FYI, sorry to partially undo your change without asking but
this is too risky for webview 51 stable.

[commit-bot: I haz the power, 2016-04-22 18:13:44]

Description was changed from

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564
==========

to

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564
==========

[commit-bot: I haz the power, 2016-04-22 18:13:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:49:49]

Description was changed from

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564
==========

to

==========
Allow null jstring to C++ string conversions in release.

WebView has too many cases where apps can pass in a null java string and
have it reach native causing a crash. For now, put back the code that
returned empty string, but keep the DCHECK so that we still hit it on
bots that run with DCHECKs enabled. We'll fix WebView and have another
go at this in a later release.

This is a partial revert of https://codereview.chromium.org/1828193002

BUG=597564

Committed: https://crrev.com/075418c032dd093e52aef9e56b8a3eb55eb7dc58
Cr-Commit-Position: refs/heads/master@{#389166}
==========

[commit-bot: I haz the power, 2016-04-22 19:49:50]

Patchset 1 (id:??) landed as
https://crrev.com/075418c032dd093e52aef9e56b8a3eb55eb7dc58
Cr-Commit-Position: refs/heads/master@{#389166}

[Bernhard Bauer, 2016-04-22 20:29:17]

Yeah, makes sense I guess.

https://codereview.chromium.org/1913183002/diff/1/base/android/jni_string.cc
File base/android/jni_string.cc (right):

https://codereview.chromium.org/1913183002/diff/1/base/android/jni_string.cc#...
base/android/jni_string.cc:29: LOG(WARNING) << "ConvertJavaStringToUTF8 called
with null string.";
FWIW, I probably would have done this with a NOTREACHED(), or a LOG(DFATAL).

[Torne, 2016-04-25 10:05:44]

On 2016/04/22 20:29:17, Bernhard Bauer wrote:
> Yeah, makes sense I guess.
> 
> https://codereview.chromium.org/1913183002/diff/1/base/android/jni_string.cc
> File base/android/jni_string.cc (right):
> 
>
https://codereview.chromium.org/1913183002/diff/1/base/android/jni_string.cc#...
> base/android/jni_string.cc:29: LOG(WARNING) << "ConvertJavaStringToUTF8 called
> with null string.";
> FWIW, I probably would have done this with a NOTREACHED(), or a LOG(DFATAL).

I just restored the old code for the release case and didn't worry too much
about exactly what it did. Hopefully we can get rid of this again fairly soon,
just not in M51. :)