Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1919623003: Rename PermissionBubbleManager to PermissionRequestManager. (Closed)

Created:
4 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 8 months ago
Reviewers:
CC:
asanka, chromium-reviews, feature-media-reviews_chromium.org, markusheintz_, mcasas+watch+vc_chromium.org, mlamouri+watch-geolocation_chromium.org, mlamouri+watch-permissions_chromium.org, msramek+watch_chromium.org, Michael van Ouwerkerk, posciak+watch_chromium.org, raymes+watch_chromium.org, tfarina, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename PermissionBubbleManager to PermissionRequestManager. This is a step toward having a generic permission request handling for all platforms instead of desktop-specific bubble system and infobar controller on Android. BUG=<TODO>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -1398 lines) Patch
M chrome/browser/chrome_quota_permission_context.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_request_limiter.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/download/download_request_limiter_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 23 chunks +63 lines, -63 lines 0 comments Download
M chrome/browser/media/media_stream_device_permission_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/midi_permission_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/media/permission_bubble_media_access_handler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_context_base.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/permissions/permission_context_base_unittest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/permissions/permission_request_manager.h View 6 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/permissions/permission_request_manager.cc View 23 chunks +37 lines, -37 lines 0 comments Download
A + chrome/browser/permissions/permission_request_manager_unittest.cc View 26 chunks +31 lines, -32 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_factory.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_factory.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/website_settings/mock_permission_bubble_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 chunk +0 lines, -194 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager.cc View 1 chunk +0 lines, -517 lines 0 comments Download
D chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc View 1 chunk +0 lines, -449 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 6 chunks +6 lines, -11 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698