Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: gpu/vulkan/vulkan_render_pass.cc

Issue 1919443002: Added copy/move constructors of complex RenderPass types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/vulkan/vulkan_render_pass.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/vulkan/vulkan_render_pass.cc
diff --git a/gpu/vulkan/vulkan_render_pass.cc b/gpu/vulkan/vulkan_render_pass.cc
index a142fc1b3ee6d38d03ad805f76c1aa915416c60a..da469d0ad96479a003fda86dce6cd7ec784ba370 100644
--- a/gpu/vulkan/vulkan_render_pass.cc
+++ b/gpu/vulkan/vulkan_render_pass.cc
@@ -99,6 +99,12 @@ bool VulkanRenderPass::AttachmentData::ValidateData(
VulkanRenderPass::SubpassData::SubpassData() {}
+VulkanRenderPass::SubpassData::SubpassData(const SubpassData& data)
piman 2016/04/22 18:23:03 nit: you can use '= default' for maintenance (if w
David Yen 2016/04/22 18:31:18 Done.
+ : subpass_attachments(data.subpass_attachments) {}
+
+VulkanRenderPass::SubpassData::SubpassData(SubpassData&& data)
+ : subpass_attachments(std::move(data.subpass_attachments)) {}
piman 2016/04/22 18:23:03 ditto
David Yen 2016/04/22 18:31:18 Done.
+
VulkanRenderPass::SubpassData::~SubpassData() {}
bool VulkanRenderPass::SubpassData::ValidateData(
@@ -126,6 +132,14 @@ bool VulkanRenderPass::SubpassData::ValidateData(
VulkanRenderPass::RenderPassData::RenderPassData() {}
+VulkanRenderPass::RenderPassData::RenderPassData(const RenderPassData& data)
+ : attachments(data.attachments),
+ subpass_datas(data.subpass_datas) {}
piman 2016/04/22 18:23:59 Both of these as well.
David Yen 2016/04/22 18:31:19 Done.
+
+VulkanRenderPass::RenderPassData::RenderPassData(RenderPassData&& data)
+ : attachments(std::move(data.attachments)),
+ subpass_datas(std::move(data.subpass_datas)) {}
+
VulkanRenderPass::RenderPassData::~RenderPassData() {}
VulkanRenderPass::VulkanRenderPass(VulkanDeviceQueue* device_queue)
« no previous file with comments | « gpu/vulkan/vulkan_render_pass.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698