Added copy/move constructors of complex RenderPass types.

gpu/vulkan/vulkan_render_pass.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/vulkan/vulkan_render_pass.h"
 
 #include "base/logging.h"
 #include "gpu/vulkan/vulkan_command_buffer.h"
 #include "gpu/vulkan/vulkan_device_queue.h"
 #include "gpu/vulkan/vulkan_image_view.h"
@@ skipping 81 matching lines @@
       return false;
     }
   }
 #endif
 
   return true;
 }
 
 VulkanRenderPass::SubpassData::SubpassData() {}
 
+VulkanRenderPass::SubpassData::SubpassData(const SubpassData& data)

[piman, 2016/04/22 18:23:03]

nit: you can use '= default' for maintenance (if we add fields etc.).

[David Yen, 2016/04/22 18:31:18]

Done.

+    : subpass_attachments(data.subpass_attachments) {}
+
+VulkanRenderPass::SubpassData::SubpassData(SubpassData&& data)
+    : subpass_attachments(std::move(data.subpass_attachments)) {}

[piman, 2016/04/22 18:23:03]

ditto

[David Yen, 2016/04/22 18:31:18]

Done.

+
 VulkanRenderPass::SubpassData::~SubpassData() {}
 
 bool VulkanRenderPass::SubpassData::ValidateData(
     uint32_t num_attachments) const {
 #if DCHECK_IS_ON()
   for (const SubpassAttachment subpass_attachment : subpass_attachments) {
     if (subpass_attachment.attachment_index >= num_attachments) {
       DLOG(ERROR) << "Invalid attachment index: "
                   << subpass_attachment.attachment_index << " < "
                   << num_attachments;
       return false;
     }
 
     const ImageLayoutType layout = subpass_attachment.subpass_layout;
     if (layout < ImageLayoutType::IMAGE_LAYOUT_TYPE_IMAGE_VIEW ||
         layout > ImageLayoutType::IMAGE_LAYOUT_TYPE_PRESENT) {
       DLOG(ERROR) << "Invalid subpass layout: " << static_cast<int>(layout);
       return false;
     }
   }
 #endif
 
   return true;
 }
 
 VulkanRenderPass::RenderPassData::RenderPassData() {}
 
+VulkanRenderPass::RenderPassData::RenderPassData(const RenderPassData& data)
+    : attachments(data.attachments),
+      subpass_datas(data.subpass_datas) {}

[piman, 2016/04/22 18:23:59]

Both of these as well.

[David Yen, 2016/04/22 18:31:19]

Done.

+
+VulkanRenderPass::RenderPassData::RenderPassData(RenderPassData&& data)
+    : attachments(std::move(data.attachments)),
+      subpass_datas(std::move(data.subpass_datas)) {}
+
 VulkanRenderPass::RenderPassData::~RenderPassData() {}
 
 VulkanRenderPass::VulkanRenderPass(VulkanDeviceQueue* device_queue)
     : device_queue_(device_queue) {}
 
 VulkanRenderPass::~VulkanRenderPass() {
   DCHECK_EQ(static_cast<VkRenderPass>(VK_NULL_HANDLE), render_pass_);
   DCHECK(frame_buffers_.empty());
 }
 
@@ skipping 253 matching lines @@
   auto iter =
       std::lower_bound(attachment_clear_indexes_.begin(),
                        attachment_clear_indexes_.end(), attachment_index);
   if (iter != attachment_clear_indexes_.end() && *iter == attachment_index) {
     const uint32_t index = iter - attachment_clear_indexes_.begin();
     attachment_clear_values_[index] = clear_value;
   }
 }
 
 }  // namespace gpu