Added copy/move constructors of complex RenderPass types.

Added copy/move constructors of complex RenderPass types.

New requirement dictates complex structs must have a defined copy/move
constructors. This CL just fixes the warnings.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0fa43c0bc8fb564e3fe0d8c8ba472a6f834a1f0f
Cr-Commit-Position: refs/heads/master@{#389206}

[David Yen, 2016-04-22 18:20:19]

Description was changed from

==========
Added copy/move constructors of complex RenderPass types.

New requirement dictates complex structs must have a defined copy/move
constructors. This CL just fixes the warnings.

R=piman@chromium.org
BUG=582558
==========

to

==========
Added copy/move constructors of complex RenderPass types.

New requirement dictates complex structs must have a defined copy/move
constructors. This CL just fixes the warnings.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[piman, 2016-04-22 18:23:04]

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
File gpu/vulkan/vulkan_render_pass.cc (right):

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:102:
VulkanRenderPass::SubpassData::SubpassData(const SubpassData& data)
nit: you can use '= default' for maintenance (if we add fields etc.).

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:106: :
subpass_attachments(std::move(data.subpass_attachments)) {}
ditto

[piman, 2016-04-22 18:23:59]

LGTM after those fixes

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
File gpu/vulkan/vulkan_render_pass.cc (right):

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:137: subpass_datas(data.subpass_datas) {}
Both of these as well.

[David Yen, 2016-04-22 18:31:19]

Great! Didn't know about this... was previously sad about the maintenance issue.

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
File gpu/vulkan/vulkan_render_pass.cc (right):

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:102:
VulkanRenderPass::SubpassData::SubpassData(const SubpassData& data)
On 2016/04/22 18:23:03, piman wrote:
> nit: you can use '= default' for maintenance (if we add fields etc.).

Done.

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:106: :
subpass_attachments(std::move(data.subpass_attachments)) {}
On 2016/04/22 18:23:03, piman wrote:
> ditto

Done.

https://codereview.chromium.org/1919443002/diff/1/gpu/vulkan/vulkan_render_pa...
gpu/vulkan/vulkan_render_pass.cc:137: subpass_datas(data.subpass_datas) {}
On 2016/04/22 18:23:59, piman wrote:
> Both of these as well.

Done.

[David Yen, 2016-04-22 18:33:20]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-04-22 18:33:20]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1919443002/#ps20001
(title: "use default")

[commit-bot: I haz the power, 2016-04-22 18:33:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1919443002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1919443002/20001

[commit-bot: I haz the power, 2016-04-22 19:22:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:51:37]

Description was changed from

==========
Added copy/move constructors of complex RenderPass types.

New requirement dictates complex structs must have a defined copy/move
constructors. This CL just fixes the warnings.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Added copy/move constructors of complex RenderPass types.

New requirement dictates complex structs must have a defined copy/move
constructors. This CL just fixes the warnings.

R=piman@chromium.org
BUG=582558
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/0fa43c0bc8fb564e3fe0d8c8ba472a6f834a1f0f
Cr-Commit-Position: refs/heads/master@{#389206}
==========

[commit-bot: I haz the power, 2016-04-22 19:51:38]

Patchset 2 (id:??) landed as
https://crrev.com/0fa43c0bc8fb564e3fe0d8c8ba472a6f834a1f0f
Cr-Commit-Position: refs/heads/master@{#389206}