Issue 1919403002: Use Polymer.dom with childNodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1919403002: Use Polymer.dom with childNodes (Closed)

Created:
4 years, 7 months ago by aiolos (Not reviewing)

Modified:
4 years, 5 months ago

Reviewers:
charliea (OOO until 10-5)

CC:
catapult-reviews_chromium.org, tracing-review_chromium.org

Base URL:
https://github.com/catapult-project/catapult.git@polymer10-migration

Target Ref:
refs/heads/polymer10-migration

Project:
catapult

Visibility:
Public.

More Reviews

Description

Use Polymer.dom with childNodes BUG=catapult:#2285 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Total comments: 1

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	tracing/tracing/ui/analysis/memory_dump_heap_details_pane_test.html	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html	View		1 chunk	+5 lines, -4 lines	1 comment	Download

Depends on Patchset:

Issue 1922863004 Patch 1

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

charliea (OOO until 10-5)

4 years, 7 months ago (2016-05-09 20:44:45 UTC) #4

https://codereview.chromium.org/1919403002/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html (right):

https://codereview.chromium.org/1919403002/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html:154:
assert.lengthOf(Polymer.do(value).childNodes, 1 + expectedInfos.length);
Should these be Polymer.dom() (instead of Polymer.do())

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages