 Chromium Code Reviews
 Chromium Code Reviews Issue 1919403002:
  Use Polymer.dom with childNodes  (Closed) 
  Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration
    
  
    Issue 1919403002:
  Use Polymer.dom with childNodes  (Closed) 
  Base URL: https://github.com/catapult-project/catapult.git@polymer10-migration| Index: tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html | 
| diff --git a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html | 
| index 4e31694d93643e79c65bde7d75fd8d81683734cb..105dafb2f37c2f904ad7f6cafccbe0da31b7ec6b 100644 | 
| --- a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html | 
| +++ b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html | 
| @@ -151,15 +151,16 @@ tr.b.unittest.testSuite(function() { | 
| function checkCellValue( | 
| test, value, expectedText, expectedColor, opt_expectedInfos) { | 
| var expectedInfos = opt_expectedInfos || []; | 
| - assert.lengthOf(value.childNodes, 1 + expectedInfos.length); | 
| + assert.lengthOf(Polymer.do(value).childNodes, 1 + expectedInfos.length); | 
| 
charliea (OOO until 10-5)
2016/05/09 20:44:45
Should these be Polymer.dom() (instead of Polymer.
 | 
| assert.strictEqual(value.style.color, expectedColor); | 
| if (typeof expectedText === 'string') | 
| - assert.strictEqual(value.childNodes[0].textContent, expectedText); | 
| + assert.strictEqual( | 
| + Polymer.do(value).childNodes[0].textContent, expectedText); | 
| else | 
| - expectedText(value.childNodes[0]); | 
| + expectedText(Polymer.do(value).childNodes[0]); | 
| for (var i = 0; i < expectedInfos.length; i++) { | 
| var expectedInfo = expectedInfos[i]; | 
| - var infoEl = value.childNodes[i + 1]; | 
| + var infoEl = Polymer.do(value).childNodes[i + 1]; | 
| assert.strictEqual(infoEl.textContent, expectedInfo.icon); | 
| assert.strictEqual(infoEl.title, expectedInfo.message); | 
| assert.strictEqual(infoEl.style.color, expectedInfo.color || ''); |