build_overrides/build.gni - Issue 1919383002: GN: Put BoringSSL Chromium specific targets inside a condition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/build.gni

Issue 1919383002: GN: Put BoringSSL Chromium specific targets inside a condition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment for build_with_chromium variable Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build_overrides/build.gni

diff --git a/build_overrides/build.gni b/build_overrides/build.gni

index 108a740f44107e95ae127261036e50f0beceaee2..482116ca6f1b068c6a9dfcad0a71acee89a66efa 100644

--- a/build_overrides/build.gni

+++ b/build_overrides/build.gni

@@ -9,3 +9,7 @@

# requires 10.7.

mac_sdk_min_build_override = "10.10"

mac_deployment_target_build_override = "10.7"

+# Variable that can be used to support multiple build scenarios, like having

+# Chromium specific targets in a client project's GN file etc.

+build_with_chromium = true

davidben 2016/04/26 21:25:16 Should this be in a boringssl.gni or maybe third_p

Dirk Pranke 2016/04/26 21:43:22 The convention is totally made up :). I think this

« no previous file with comments | « no previous file | build_overrides/webrtc.gni » ('j') | no next file with comments »